Skip to content

Commit 095c7b5

Browse files
authored
Merge branch 'main' into yir-re-design
2 parents 1379200 + 452b720 commit 095c7b5

File tree

9 files changed

+19
-39
lines changed

9 files changed

+19
-39
lines changed

app/build.gradle

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -275,7 +275,6 @@ dependencies {
275275
def composeBom = platform(libs.composeBom)
276276
implementation(composeBom)
277277
implementation(libs.compose.material3)
278-
implementation(libs.compose.material.icons)
279278
implementation(libs.compose.ui)
280279
implementation(libs.compose.ui.tooling.preview)
281280
debugImplementation(libs.compose.ui.tooling)

app/src/main/java/org/wikipedia/compose/components/SearchEmptyView.kt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,17 +8,17 @@ import androidx.compose.foundation.layout.fillMaxSize
88
import androidx.compose.foundation.layout.padding
99
import androidx.compose.foundation.layout.requiredSize
1010
import androidx.compose.foundation.shape.CircleShape
11-
import androidx.compose.material.icons.Icons
12-
import androidx.compose.material.icons.outlined.Search
1311
import androidx.compose.material3.Icon
1412
import androidx.compose.material3.MaterialTheme
1513
import androidx.compose.material3.Text
1614
import androidx.compose.runtime.Composable
1715
import androidx.compose.ui.Alignment
1816
import androidx.compose.ui.Modifier
1917
import androidx.compose.ui.draw.clip
18+
import androidx.compose.ui.res.painterResource
2019
import androidx.compose.ui.tooling.preview.Preview
2120
import androidx.compose.ui.unit.dp
21+
import org.wikipedia.R
2222
import org.wikipedia.compose.theme.BaseTheme
2323
import org.wikipedia.compose.theme.WikipediaTheme
2424
import org.wikipedia.theme.Theme
@@ -39,7 +39,7 @@ fun SearchEmptyView(
3939
.clip(CircleShape)
4040
.background(WikipediaTheme.colors.backgroundColor)
4141
.padding(20.dp),
42-
imageVector = Icons.Outlined.Search,
42+
painter = painterResource(R.drawable.outline_search_24),
4343
tint = WikipediaTheme.colors.placeholderColor,
4444
contentDescription = null
4545
)

app/src/main/java/org/wikipedia/compose/components/SearchTopAppBar.kt

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,6 @@ package org.wikipedia.compose.components
33
import androidx.compose.foundation.layout.RowScope
44
import androidx.compose.foundation.layout.fillMaxWidth
55
import androidx.compose.foundation.layout.padding
6-
import androidx.compose.material.icons.Icons
7-
import androidx.compose.material.icons.automirrored.filled.ArrowBack
86
import androidx.compose.material3.ExperimentalMaterial3Api
97
import androidx.compose.material3.Icon
108
import androidx.compose.material3.IconButton
@@ -22,6 +20,7 @@ import androidx.compose.ui.focus.focusRequester
2220
import androidx.compose.ui.graphics.Color
2321
import androidx.compose.ui.platform.LocalContext
2422
import androidx.compose.ui.platform.testTag
23+
import androidx.compose.ui.res.painterResource
2524
import androidx.compose.ui.res.stringResource
2625
import androidx.compose.ui.text.TextStyle
2726
import androidx.compose.ui.unit.dp
@@ -75,7 +74,7 @@ fun SearchTopAppBar(
7574
onBackButtonClick()
7675
}) {
7776
Icon(
78-
imageVector = Icons.AutoMirrored.Filled.ArrowBack,
77+
painter = painterResource(R.drawable.ic_arrow_back_black_24dp),
7978
contentDescription = stringResource(R.string.search_back_button_content_description),
8079
tint = WikipediaTheme.colors.primaryColor
8180
)

app/src/main/java/org/wikipedia/compose/components/WikiTopAppBar.kt

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
package org.wikipedia.compose.components
22

33
import androidx.compose.foundation.layout.RowScope
4-
import androidx.compose.material.icons.Icons
5-
import androidx.compose.material.icons.automirrored.filled.ArrowBack
64
import androidx.compose.material3.ExperimentalMaterial3Api
75
import androidx.compose.material3.Icon
86
import androidx.compose.material3.IconButton
@@ -14,6 +12,7 @@ import androidx.compose.runtime.Composable
1412
import androidx.compose.ui.Modifier
1513
import androidx.compose.ui.draw.shadow
1614
import androidx.compose.ui.platform.LocalContext
15+
import androidx.compose.ui.res.painterResource
1716
import androidx.compose.ui.res.stringResource
1817
import androidx.compose.ui.text.TextStyle
1918
import androidx.compose.ui.text.font.FontWeight
@@ -53,7 +52,7 @@ fun WikiTopAppBar(
5352
onNavigationClick()
5453
}) {
5554
Icon(
56-
imageVector = Icons.AutoMirrored.Filled.ArrowBack,
55+
painter = painterResource(R.drawable.outline_search_24),
5756
tint = WikipediaTheme.colors.primaryColor,
5857
contentDescription = stringResource(R.string.search_back_button_content_description)
5958
)

app/src/main/java/org/wikipedia/compose/components/WikiTopAppBarWithSearch.kt

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,16 +7,14 @@ import androidx.compose.animation.core.tween
77
import androidx.compose.animation.fadeIn
88
import androidx.compose.animation.fadeOut
99
import androidx.compose.animation.togetherWith
10-
import androidx.compose.material.icons.Icons
11-
import androidx.compose.material.icons.outlined.Clear
12-
import androidx.compose.material.icons.outlined.Search
1310
import androidx.compose.material3.Icon
1411
import androidx.compose.material3.IconButton
1512
import androidx.compose.runtime.Composable
1613
import androidx.compose.runtime.getValue
1714
import androidx.compose.runtime.mutableStateOf
1815
import androidx.compose.runtime.remember
1916
import androidx.compose.runtime.setValue
17+
import androidx.compose.ui.res.painterResource
2018
import androidx.compose.ui.res.stringResource
2119
import org.wikipedia.R
2220
import org.wikipedia.compose.theme.WikipediaTheme
@@ -85,7 +83,7 @@ fun WikiTopAppBarWithSearch(
8583
},
8684
content = {
8785
Icon(
88-
imageVector = Icons.Outlined.Clear,
86+
painter = painterResource(R.drawable.ic_close_black_24dp),
8987
contentDescription = stringResource(R.string.search_clear_query_content_description),
9088
tint = WikipediaTheme.colors.placeholderColor
9189
)
@@ -106,7 +104,7 @@ fun WikiTopAppBarWithSearch(
106104
},
107105
content = {
108106
Icon(
109-
imageVector = Icons.Outlined.Search,
107+
painter = painterResource(R.drawable.outline_search_24),
110108
contentDescription = stringResource(R.string.search_icon_content_description),
111109
tint = WikipediaTheme.colors.primaryColor
112110
)

app/src/main/java/org/wikipedia/donate/donationreminder/DonationReminderScreen.kt

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,6 @@ import androidx.compose.foundation.shape.RoundedCornerShape
1919
import androidx.compose.foundation.text.KeyboardActions
2020
import androidx.compose.foundation.text.KeyboardOptions
2121
import androidx.compose.foundation.verticalScroll
22-
import androidx.compose.material.icons.Icons
23-
import androidx.compose.material.icons.filled.ArrowDropDown
24-
import androidx.compose.material.icons.filled.Favorite
25-
import androidx.compose.material.icons.filled.Info
2622
import androidx.compose.material3.DropdownMenu
2723
import androidx.compose.material3.DropdownMenuItem
2824
import androidx.compose.material3.ExperimentalMaterial3Api
@@ -472,7 +468,7 @@ fun DonationHeader(
472468
modifier = Modifier
473469
.size(20.dp)
474470
.padding(start = 4.dp),
475-
imageVector = Icons.Filled.Favorite,
471+
painter = painterResource(R.drawable.ic_heart_24),
476472
contentDescription = null,
477473
tint = WikipediaTheme.colors.destructiveColor
478474
)
@@ -544,7 +540,7 @@ fun <T : Number>OptionSelector(
544540
),
545541
trailingIcon = {
546542
Icon(
547-
imageVector = Icons.Filled.ArrowDropDown,
543+
painter = painterResource(R.drawable.ic_arrow_drop_down_black_24dp),
548544
tint = WikipediaTheme.colors.primaryColor,
549545
contentDescription = null
550546
)
@@ -749,7 +745,7 @@ fun CustomInputDialog(
749745
trailingIcon = if (errorMessage.isNotEmpty()) {
750746
{
751747
Icon(
752-
imageVector = Icons.Default.Info,
748+
painter = painterResource(R.drawable.baseline_info_24),
753749
contentDescription = null,
754750
tint = WikipediaTheme.colors.destructiveColor
755751
)

app/src/main/java/org/wikipedia/readinglist/recommended/RecommendedReadingListInterestsFragment.kt

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -32,11 +32,6 @@ import androidx.compose.foundation.lazy.staggeredgrid.StaggeredGridItemSpan
3232
import androidx.compose.foundation.lazy.staggeredgrid.items
3333
import androidx.compose.foundation.lazy.staggeredgrid.rememberLazyStaggeredGridState
3434
import androidx.compose.foundation.shape.RoundedCornerShape
35-
import androidx.compose.material.icons.Icons
36-
import androidx.compose.material.icons.automirrored.filled.ArrowBack
37-
import androidx.compose.material.icons.automirrored.filled.ArrowForward
38-
import androidx.compose.material.icons.filled.CheckCircle
39-
import androidx.compose.material.icons.filled.Search
4035
import androidx.compose.material3.CardDefaults
4136
import androidx.compose.material3.ExperimentalMaterial3Api
4237
import androidx.compose.material3.Icon
@@ -258,7 +253,7 @@ fun RecommendedReadingListInterestsScreen(
258253
navigationIcon = {
259254
val enabled = !fromSettings || (uiState !is Resource.Success) || uiState.data.selectedItems.isNotEmpty()
260255
Icon(
261-
imageVector = Icons.AutoMirrored.Filled.ArrowBack,
256+
painter = painterResource(R.drawable.ic_arrow_back_black_24dp),
262257
contentDescription = stringResource(R.string.search_back_button_content_description),
263258
modifier = Modifier
264259
.size(48.dp)
@@ -435,7 +430,7 @@ fun RecommendedReadingListInterestsContent(
435430
.clickable(enabled = selectedItems.isNotEmpty(), onClick = onNextClick)
436431
.padding(12.dp)
437432
.alpha(if (selectedItems.isNotEmpty()) 1f else 0.5f),
438-
imageVector = Icons.AutoMirrored.Filled.ArrowForward,
433+
painter = painterResource(R.drawable.ic_arrow_forward_black_24dp),
439434
tint = WikipediaTheme.colors.primaryColor,
440435
contentDescription = stringResource(R.string.nav_item_forward)
441436
)
@@ -510,7 +505,7 @@ fun ReadingListInterestCard(
510505
Spacer(modifier = Modifier.width(8.dp))
511506
Icon(
512507
modifier = Modifier.size(24.dp).align(Alignment.Bottom),
513-
imageVector = Icons.Default.CheckCircle,
508+
painter = painterResource(R.drawable.check_circle_24px),
514509
tint = WikipediaTheme.colors.primaryColor,
515510
contentDescription = null
516511
)
@@ -539,7 +534,7 @@ fun ReadingListInterestSearchCard(onSearchClick: () -> Unit) {
539534
) {
540535
Spacer(modifier = Modifier.width(16.dp))
541536
Icon(
542-
imageVector = Icons.Default.Search,
537+
painter = painterResource(R.drawable.outline_search_24),
543538
contentDescription = stringResource(R.string.search_hint),
544539
tint = WikipediaTheme.colors.secondaryColor,
545540
modifier = Modifier.size(24.dp)

app/src/main/java/org/wikipedia/readinglist/recommended/RecommendedReadingListSourceScreen.kt

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,6 @@ import androidx.compose.foundation.layout.padding
1616
import androidx.compose.foundation.layout.size
1717
import androidx.compose.foundation.rememberScrollState
1818
import androidx.compose.foundation.verticalScroll
19-
import androidx.compose.material.icons.Icons
20-
import androidx.compose.material.icons.automirrored.filled.ArrowBack
21-
import androidx.compose.material.icons.automirrored.filled.ArrowForward
22-
import androidx.compose.material.icons.filled.Close
2319
import androidx.compose.material3.CardDefaults
2420
import androidx.compose.material3.ExperimentalMaterial3Api
2521
import androidx.compose.material3.Icon
@@ -86,7 +82,7 @@ fun SourceSelectionScreen(
8682
},
8783
navigationIcon = {
8884
Icon(
89-
imageVector = if (fromSettings) Icons.AutoMirrored.Filled.ArrowBack else Icons.Default.Close,
85+
painter = painterResource(if (fromSettings) R.drawable.ic_arrow_back_black_24dp else R.drawable.ic_close_black_24dp),
9086
contentDescription = stringResource(id = if (fromSettings) R.string.search_back_button_content_description else R.string.table_close),
9187
modifier = Modifier
9288
.size(48.dp)
@@ -247,7 +243,7 @@ fun SourceSelectionContent(
247243
.background(WikipediaTheme.colors.borderColor)
248244
)
249245
Icon(
250-
imageVector = Icons.AutoMirrored.Filled.ArrowForward,
246+
painter = painterResource(R.drawable.ic_arrow_forward_black_24dp),
251247
contentDescription = stringResource(R.string.nav_item_forward),
252248
tint = WikipediaTheme.colors.primaryColor,
253249
modifier = Modifier

gradle/libs.versions.toml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,6 @@ viewpager2 = "1.1.0"
4949
workRuntimeKtx = "2.10.5"
5050
composeBom = "2025.09.01"
5151
composeActivity = "1.11.0"
52-
composeMaterialIcons = "1.7.8"
5352
composeViewModel = "2.9.4"
5453

5554

@@ -120,7 +119,6 @@ viewpager2 = { module = "androidx.viewpager2:viewpager2", version.ref = "viewpag
120119
work-runtime-ktx = { module = "androidx.work:work-runtime-ktx", version.ref = "workRuntimeKtx" }
121120
composeBom = { module = "androidx.compose:compose-bom", version.ref = "composeBom" }
122121
compose-material3 = { module = "androidx.compose.material3:material3" }
123-
compose-material-icons = { module = "androidx.compose.material:material-icons-core", version.ref = "composeMaterialIcons" }
124122
compose-ui = { module = "androidx.compose.ui:ui" }
125123
compose-ui-tooling-preview = { module = "androidx.compose.ui:ui-tooling-preview" }
126124
compose-ui-tooling = { module = "androidx.compose.ui:ui-tooling" }

0 commit comments

Comments
 (0)