YiR: Clear out persisted model data upon logout. (#6112)

Co-authored-by: William Rai <[email protected]>

Author: dbrant

app/src/main/java/org/wikipedia/WikipediaApp.kt

@@ -259,6 +259,7 @@ class WikipediaApp : Application() {
         Prefs.tempAccountDialogShown = false
         Prefs.impactLastQueryTime = 0
         Prefs.impactLastResponseBody = emptyMap()
+        Prefs.yearInReviewModelData = emptyMap()
         SharedPreferenceCookieManager.instance.clearAllCookies()
         MainScope().launch {
             AppDatabase.instance.notificationDao().deleteAll()

app/src/main/java/org/wikipedia/settings/SettingsPreferenceLoader.kt

@@ -84,9 +84,6 @@ internal class SettingsPreferenceLoader(fragment: PreferenceFragmentCompat) : Ba
                     .setPositiveButton(R.string.year_in_review_disable_positive_button) { _, _ ->
                         YearInReviewEvent.submit(action = "yir_off_confirm_click", slide = "setting")
                         Prefs.yearInReviewModelData = emptyMap()
-                        YearInReviewViewModel.updateYearInReviewModel { model ->
-                            model.copy(slideViewedCount = 0)
-                        }
                         Prefs.yearInReviewReadingListSurveyShown = false
                         Prefs.yearInReviewReadingListVisitCount = 0
                         (preference as SwitchPreferenceCompat).isChecked = false