Use string resource for view changes button and some minor code updates (#5901)

* Use string resource for view changes button and some minor code updates

* More thumbnail url update

Author: cooltey

app/src/main/java/org/wikipedia/activitytab/EditingInsightsModule.kt

@@ -243,7 +243,7 @@ fun MostViewedCard(
                                 )
                             }
                         }
-                        if (pageTitle.thumbUrl != null) {
+                        if (!pageTitle.thumbUrl.isNullOrEmpty()) {
                             val request =
                                 ImageService.getRequest(
                                     LocalContext.current,

app/src/main/java/org/wikipedia/activitytab/ReadingHistoryModule.kt

@@ -426,7 +426,7 @@ private fun ArticleSavedThisMonthCard(
 
                     for (i in 0 until itemsToShow) {
                         val url = readingHistory.articlesSaved[i].thumbUrl
-                        if (url == null) {
+                        if (url.isNullOrEmpty()) {
                             Box(
                                 modifier = Modifier.padding(start = 4.dp).size(38.dp)
                                     .background(

app/src/main/java/org/wikipedia/activitytab/timeline/TimelineModule.kt

@@ -116,12 +116,12 @@ fun TimelineModule(
                     )
                     Text(
                         modifier = Modifier.padding(start = 6.dp),
-                        text = "View changes"
+                        text = stringResource(R.string.activity_tab_timeline_view_changes_button)
                     )
                 }
             }
         }
-        if (timelineItem.thumbnailUrl != null) {
+        if (!timelineItem.thumbnailUrl.isNullOrEmpty()) {
             val request =
                 ImageService.getRequest(LocalContext.current, url = timelineItem.thumbnailUrl)
             AsyncImage(
@@ -206,7 +206,7 @@ fun TimelineDateSeparator(
     }
 }
 
-@Preview
+@Preview(showBackground = true)
 @Composable
 private fun TimelineItemPreview() {
     BaseTheme(
@@ -231,7 +231,7 @@ private fun TimelineItemPreview() {
     }
 }
 
-@Preview
+@Preview(showBackground = true)
 @Composable
 private fun TimelineDateSeparatorPreview() {
     BaseTheme(

app/src/main/res/values-qq/strings.xml

@@ -1242,6 +1242,7 @@
   <string name="activity_tab_timeline_yesterday">Date separator label for yesterday\'s entries in activity timeline.</string>
   <string name="activity_tab_timeline_empty_state_title">Title displayed when the timeline is empty.</string>
   <string name="activity_tab_timeline_empty_state_message">Message shown when there are no items in the timeline.</string>
+  <string name="activity_tab_timeline_view_changes_button">Button label to view edit changes in the timeline.</string>
   <string name="activity_tab_onboarding_screen_title">Title for the activity tab onboarding screen.</string>
   <string name="activity_tab_onboarding_reading_patterns_title">Title for the section about user\'s reading habits.</string>
   <string name="activity_tab_onboarding_reading_patterns_message">Short explanation about user\'s reading habits.</string>

app/src/main/res/values/strings.xml

@@ -1264,6 +1264,7 @@
     <string name="activity_tab_timeline_yesterday">Yesterday</string>
     <string name="activity_tab_timeline_empty_state_title">Nothing to show</string>
     <string name="activity_tab_timeline_empty_state_message">Start reading and editing to build your history</string>
+    <string name="activity_tab_timeline_view_changes_button">View changes</string>
     <string name="activity_tab_onboarding_reading_patterns_title">Reading patterns</string>
     <string name="activity_tab_onboarding_reading_patterns_message">See how much time you\'ve spent reading and which articles or topics you\'ve explored over time.</string>
     <string name="activity_tab_onboarding_screen_title">Introducing Activity</string>