Merge pull request #3599 from wordpress-mobile/issue/3594-webview-crash-on-app-start

Fix #3594 webview crash on app start

Author: nbradbury

WordPress/src/main/java/org/wordpress/android/WordPress.java

@@ -14,6 +14,7 @@
 import android.os.StrictMode;
 import android.os.SystemClock;
 import android.text.TextUtils;
+import android.util.AndroidRuntimeException;
 import android.webkit.WebView;
 
 import com.android.volley.RequestQueue;
@@ -574,7 +575,14 @@ public static String getLoginUrl(Blog blog) {
     public static String getDefaultUserAgent() {
         if (mDefaultUserAgent == null) {
             // TODO: use WebSettings.getDefaultUserAgent() after upgrade to API level 17+
-            mDefaultUserAgent = new WebView(getContext()).getSettings().getUserAgentString();
+            try {
+                // Catch AndroidRuntimeException that could be raised by the WebView() constructor.
+                // See https://github.com/wordpress-mobile/WordPress-Android/issues/3594
+                mDefaultUserAgent = new WebView(getContext()).getSettings().getUserAgentString();
+            } catch (AndroidRuntimeException e) {
+                // init with the empty string, it's a rare issue
+                mDefaultUserAgent = "";
+            }
         }
         return mDefaultUserAgent;
     }
@@ -592,8 +600,13 @@ public static String getDefaultUserAgent() {
     private static String mUserAgent;
     public static String getUserAgent() {
         if (mUserAgent == null) {
-            mUserAgent = getDefaultUserAgent() + " "
-                       + USER_AGENT_APPNAME + "/" + PackageUtils.getVersionName(getContext());
+            String defaultUserAgent = getDefaultUserAgent();
+            if (TextUtils.isEmpty(defaultUserAgent)) {
+                mUserAgent = USER_AGENT_APPNAME + "/" + PackageUtils.getVersionName(getContext());
+            } else {
+                mUserAgent = defaultUserAgent + " "+ USER_AGENT_APPNAME + "/"
+                        + PackageUtils.getVersionName(getContext());
+            }
         }
         return mUserAgent;
     }