Merge pull request #4675 from wordpress-mobile/issue/4665-jetpack-settings-jump

Move the awful layout code into the right lifecycle method

Author: astralbodies

WordPress/Classes/ViewRelated/Stats/JetpackSettingsViewController.m

@@ -75,7 +75,7 @@ @implementation JetpackSettingsViewController
 
 - (instancetype)initWithBlog:(Blog *)blog
 {
-    self = [super init];
+    self = [self init];
     if (self) {
         _blog = blog;
         _showFullScreen = YES;
@@ -95,6 +95,8 @@ - (BOOL)hidesBottomBarWhenPushed
 
 - (void)willAnimateRotationToInterfaceOrientation:(UIInterfaceOrientation)toInterfaceOrientation duration:(NSTimeInterval)duration
 {
+    [super willAnimateRotationToInterfaceOrientation:toInterfaceOrientation duration:duration];
+    
     [self layoutControls];
 }
 
@@ -104,9 +106,23 @@ - (void)willAnimateRotationToInterfaceOrientation:(UIInterfaceOrientation)toInte
 - (void)viewWillAppear:(BOOL)animated
 {
     [super viewWillAppear:animated];
+
     [self.navigationController setNavigationBarHidden:self.showFullScreen animated:animated];
+}
+
+- (void)viewDidLayoutSubviews
+{
+    [super viewDidLayoutSubviews];
+
     [self reloadInterface];
     [self updateForm];
+}
+
+
+- (void)viewDidAppear:(BOOL)animated
+{
+    [super viewDidAppear:animated];
+
     [self checkForJetpack];
 }
 
@@ -130,13 +146,6 @@ - (void)viewDidLoad
     [self addSkipButtonIfNeeded];
 }
 
-// This resolves a crash due to JetpackSettingsViewController previously using a .xib.
-// Source: http://stackoverflow.com/questions/17708292/not-key-value-coding-compliant-error-from-deleted-xib
-- (void)loadView
-{
-    [super loadView];
-}
-
 - (void)addControls
 {
     // Add Logo