Skip to content

Commit 4b08b5d

Browse files
committed
Merge pull request #4714 from /issues/4663-changes-jpeg-to-jpg
Media: Use jpg instead of jpeg for uploaded image extension
2 parents 4d3ae9c + 9e07b14 commit 4b08b5d

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

WordPress/Classes/Services/MediaService.m

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,12 @@ - (void)uploadMedia:(Media *)media
141141
{
142142
id<MediaServiceRemote> remote = [self remoteForBlog:media.blog];
143143
RemoteMedia *remoteMedia = [self remoteMediaFromMedia:media];
144-
144+
145+
// Even though jpeg is a valid extension, use jpg instead for the widest possible
146+
// support. Some third-party image related plugins prefer the .jpg extension.
147+
// See https://github.com/wordpress-mobile/WordPress-iOS/issues/4663
148+
remoteMedia.file = [remoteMedia.file stringByReplacingOccurrencesOfString:@".jpeg" withString:@".jpg"];
149+
145150
media.remoteStatus = MediaRemoteStatusPushing;
146151
[[ContextManager sharedInstance] saveContext:self.managedObjectContext];
147152
NSManagedObjectID *mediaObjectID = media.objectID;

WordPress/Classes/ViewRelated/Media/MediaLibraryPickerDataSource.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ - (void)addImage:(UIImage *)image
148148
completionBlock:(WPMediaAddedBlock)completionBlock
149149
{
150150
[self addAssetWithChangeRequest:^PHAssetChangeRequest *{
151-
NSString *fileName = [NSString stringWithFormat:@"%@_%@", [[NSProcessInfo processInfo] globallyUniqueString], @".jpeg"];
151+
NSString *fileName = [NSString stringWithFormat:@"%@_%@", [[NSProcessInfo processInfo] globallyUniqueString], @".jpg"];
152152
NSURL *fileURL = [NSURL fileURLWithPath:[NSTemporaryDirectory() stringByAppendingPathComponent:fileName]];
153153
NSError *error;
154154
if ([image writeToURL:fileURL type:(__bridge NSString *)kUTTypeJPEG compressionQuality:0.9 metadata:metadata error:&error]){

0 commit comments

Comments
 (0)