Merge pull request #104 from xendit/feat/ewallet-agnostic-channel-props

feat(ewallet): make channelProps object wallet-agnostic

Author: stanleynguyen

README.md

@@ -657,7 +657,7 @@ ew.createEWalletCharge(data: {
   amount: number;
   checkoutMethod: string;
   channelCode?: ChannelCode;
-  channelProperties?: OVOChannelProps | PaymayaChannelProps | OtherChannelProps;
+  channelProperties?: ChannelProps;
   customerID?: string;
   basket?: Basket[];
   metadata?: object;

package-lock.json

@@ -51,7 +51,7 @@
   },
   "homepage": "https://github.com/xendit/xendit-node#readme",
   "dependencies": {
-    "node-fetch": "^2.6.0"
+    "node-fetch": "^2.6.1"
   },
   "devDependencies": {
     "@typescript-eslint/eslint-plugin": "^2.13.0",

package.json

@@ -31,18 +31,12 @@ enum ChannelCode {
   PH_PAYMAYA = 'PH_PAYMAYA',
 }
 
-interface OVOChannelProps {
-  mobileNumber: string;
-}
-
-interface PaymayaChannelProps {
-  successRedirectURL: string;
-  failureRedirectURL: string;
-  cancelRedirectURL: string;
-}
-
-interface OtherChannelProps {
-  successRedirectURL: string;
+interface ChannelProps {
+  mobileNumber?: string;
+  successRedirectURL?: string;
+  failureRedirectURL?: string;
+  cancelRedirectURL?: string;
+  redeemPoints?: string;
 }
 
 interface Basket {
@@ -90,10 +84,7 @@ export = class EWallet {
     amount: number;
     checkoutMethod: string;
     channelCode?: ChannelCode;
-    channelProperties?:
-      | OVOChannelProps
-      | PaymayaChannelProps
-      | OtherChannelProps;
+    channelProperties?: ChannelProps;
     customerID?: string;
     basket?: Basket[];
     metadata?: object;

src/ewallet/ewallet.d.ts

@@ -153,20 +153,15 @@ EWallet.prototype.createEWalletCharge = function(data) {
         amount: data.amount,
         checkout_method: data.checkoutMethod,
         channel_code: data.channelCode,
-        channel_properties:
-          data.channelCode === 'ID_OVO'
-            ? {
-                mobile_number: data.channelProperties.mobileNumber,
-              }
-            : data.channelCode === 'PH_PAYMAYA'
-            ? {
-                success_redirect_url: data.channelProperties.successRedirectURL,
-                failure_redirect_url: data.channelProperties.failureRedirectURL,
-                cancel_redirect_url: data.channelProperties.cancelRedirectURL,
-              }
-            : {
-                success_redirect_url: data.channelProperties.successRedirectURL,
-              },
+        channel_properties: data.channelProperties
+          ? {
+              mobile_number: data.channelProperties.mobileNumber,
+              success_redirect_url: data.channelProperties.successRedirectURL,
+              failure_redirect_url: data.channelProperties.failureRedirectURL,
+              cancel_redirect_url: data.channelProperties.cancelRedirectURL,
+              redeem_points: data.channelProperties.redeemPoints,
+            }
+          : data.channelProperties,
         customer_id: data.customerID,
         basket: data.basket
           ? data.basket.map(product => ({