[Misc] Migrate tests to JUnit5 + fix SonarQube-reported issues + fix some pom typos

Author: vmassol

xwiki-rendering-standalone/pom.xml

@@ -135,7 +135,6 @@
       <groupId>org.slf4j</groupId>
       <artifactId>log4j-over-slf4j</artifactId>
     </dependency>
-
     <!-- Test Dependencies -->
     <dependency>
       <groupId>org.xwiki.commons</groupId>
@@ -170,7 +169,7 @@
               <goal>test</goal>
             </goals>
             <configuration>
-              <!-- Removed modules for which a Legacy module exist and wraps it -->
+              <!-- Removed modules for which a Legacy module exists and wraps it -->
               <classpathDependencyExcludes>
                 <classpathDependencyExcludes>org.xwiki.commons:xwiki-commons-component-api</classpathDependencyExcludes>
                 <classpathDependencyExcludes>org.xwiki.commons:xwiki-commons-component-default</classpathDependencyExcludes>

xwiki-rendering-syntaxes/xwiki-rendering-syntax-html5/src/test/java/org/xwiki/rendering/internal/html5/HTML5ChainingRendererTest.java

@@ -22,16 +22,16 @@
 import java.util.HashMap;
 import java.util.Map;
 
-import org.junit.Before;
-import org.junit.Test;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
 import org.xwiki.rendering.internal.renderer.html5.HTML5ChainingRenderer;
 import org.xwiki.rendering.internal.renderer.xhtml.image.XHTMLImageRenderer;
 import org.xwiki.rendering.internal.renderer.xhtml.link.XHTMLLinkRenderer;
 import org.xwiki.rendering.listener.Format;
 import org.xwiki.rendering.listener.chaining.ListenerChain;
 import org.xwiki.rendering.renderer.printer.DefaultWikiPrinter;
 
-import static org.junit.Assert.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.mockito.Mockito.mock;
 
 /**
@@ -40,58 +40,51 @@
  * @version $Id$
  * @since 7.1M1
  */
-public class HTML5ChainingRendererTest
+class HTML5ChainingRendererTest
 {
-    private XHTMLLinkRenderer linkRenderer;
-    
-    private XHTMLImageRenderer imageRenderer;
-    
-    private ListenerChain listenerChain;
-    
     private HTML5ChainingRenderer chainingRenderer;
-    
+
     private DefaultWikiPrinter printer;
 
-    @Before
-    public void setUp() throws Exception
+    @BeforeEach
+    void setUp()
     {
-        linkRenderer = mock(XHTMLLinkRenderer.class);
-        imageRenderer = mock(XHTMLImageRenderer.class);
-        listenerChain = new ListenerChain();
-        chainingRenderer = new HTML5ChainingRenderer(linkRenderer, imageRenderer, null, listenerChain);
-        printer = new DefaultWikiPrinter();
-        chainingRenderer.setPrinter(printer);
+        XHTMLLinkRenderer linkRenderer = mock(XHTMLLinkRenderer.class);
+        XHTMLImageRenderer imageRenderer = mock(XHTMLImageRenderer.class);
+        ListenerChain listenerChain = new ListenerChain();
+        this.chainingRenderer = new HTML5ChainingRenderer(linkRenderer, imageRenderer, null, listenerChain);
+        this.printer = new DefaultWikiPrinter();
+        this.chainingRenderer.setPrinter(this.printer);
     }
 
     @Test
-    public void testWithoutMonospace() throws Exception
+    void withoutMonospace()
     {   
         Map<String, String> parameters = new HashMap<>();
-        chainingRenderer.beginFormat(Format.BOLD, parameters);
-        chainingRenderer.onWord("hello");
-        chainingRenderer.endFormat(Format.BOLD, parameters);
-        assertEquals("<strong>hello</strong>", printer.toString());
+        this.chainingRenderer.beginFormat(Format.BOLD, parameters);
+        this.chainingRenderer.onWord("hello");
+        this.chainingRenderer.endFormat(Format.BOLD, parameters);
+        assertEquals("<strong>hello</strong>", this.printer.toString());
     }
 
     @Test
-    public void testWithMonospace() throws Exception
+    void withMonospace()
     {
         Map<String, String> parameters = new HashMap<>();
-        chainingRenderer.beginFormat(Format.MONOSPACE, parameters);
-        chainingRenderer.onWord("hello");
-        chainingRenderer.endFormat(Format.MONOSPACE, parameters);
-        assertEquals("<span class=\"monospace\">hello</span>", printer.toString());
+        this.chainingRenderer.beginFormat(Format.MONOSPACE, parameters);
+        this.chainingRenderer.onWord("hello");
+        this.chainingRenderer.endFormat(Format.MONOSPACE, parameters);
+        assertEquals("<span class=\"monospace\">hello</span>", this.printer.toString());
     }
 
     @Test
-    public void testWithMonospaceAndParameters() throws Exception
+    void withMonospaceAndParameters()
     {
         Map<String, String> parameters = new HashMap<>();
         parameters.put("class", "myClass");
-        chainingRenderer.beginFormat(Format.MONOSPACE, parameters);
-        chainingRenderer.onWord("hello");
-        chainingRenderer.endFormat(Format.MONOSPACE, parameters);
-        assertEquals("<span class=\"monospace myClass\">hello</span>", printer.toString());
+        this.chainingRenderer.beginFormat(Format.MONOSPACE, parameters);
+        this.chainingRenderer.onWord("hello");
+        this.chainingRenderer.endFormat(Format.MONOSPACE, parameters);
+        assertEquals("<span class=\"monospace myClass\">hello</span>", this.printer.toString());
     }
-    
 }