Skip to content

Commit 3fe71ab

Browse files
authored
Use array syntax for commands in docker-compose-base.yml (infiniflow#11391)
Use array syntax in order to prevent parameter quoting issues. This also runs the command directly without a bash process, which means signals (like SIGTERM) will be delivered directly to the server process. Fixes issue infiniflow#11390 ### What problem does this PR solve? `${REDIS_PASSWORD}` was not passed correctly, meaning if it was unset or contains spaces (or shell code!) it was interpreted wrongly. ### Type of change - [x] Bug Fix (non-breaking change which fixes an issue)
1 parent 9f715d6 commit 3fe71ab

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

docker/docker-compose-base.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,7 @@ services:
179179

180180
minio:
181181
image: quay.io/minio/minio:RELEASE.2025-06-13T11-33-47Z
182-
command: server --console-address ":9001" /data
182+
command: ["server", "--console-address", ":9001", "/data"]
183183
ports:
184184
- ${MINIO_PORT}:9000
185185
- ${MINIO_CONSOLE_PORT}:9001
@@ -201,7 +201,7 @@ services:
201201
redis:
202202
# swr.cn-north-4.myhuaweicloud.com/ddn-k8s/docker.io/valkey/valkey:8
203203
image: valkey/valkey:8
204-
command: redis-server --requirepass ${REDIS_PASSWORD} --maxmemory 128mb --maxmemory-policy allkeys-lru
204+
command: ["redis-server", "--requirepass", "${REDIS_PASSWORD}", "--maxmemory", "128mb", "--maxmemory-policy", "allkeys-lru"]
205205
env_file: .env
206206
ports:
207207
- ${REDIS_PORT}:6379

0 commit comments

Comments
 (0)