-
Notifications
You must be signed in to change notification settings - Fork 131
Update jsonwebtoken dependency #409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Sorry for failed CI |
|
Hi @DoumanAsh I would like to proceed with the removal of |
c2a8f38 to
cc5819c
Compare
|
@yoshidan So, just removing method will cause you to attempt to construct invalid key (since there is no key) so I had to switch to |
|
@yoshidan there seems to be some cargo deny issue with dependencies: It doesn't like licenses... I'm not really sure why someone would make such check, but bigger issue is |
I agree. The following actions made PR work in my enviroment.
% cargo deny --workspace --all-features --log-level=error check
advisories ok, bans ok, licenses ok, sources ok |
|
I actually wanted to avoid depending on aws-lc, but jsonwebtoken's crypto backend is not flexible to have ring implementation (or any alternative implementation for that matter), so it seems to be the only choice for now, which is unfortunate... |
|
Thank you for your contribution. |
I would like to remove multiple instances of
jsonwebtokenin my dependency tree so I wanted to bump in this crate as I rely on it (This version introduces user's choice of crypto libraries so I defaulted to rust's one as it was before)Unfortunately
jsonwebtokenwants to deprecate useful API:Suggested alternative does not validate
audienceWould you like me to implement
audiencevalidation as part of upgrade PR? (I'm not sure how critical it is in context of where signature validation is skipped, so if it is ok to skip validation, I can change code to usejsonwebtoken::dangerous::insecure_decode)