Skip to content

Commit 679cd8b

Browse files
committed
fix: SSE handler template blocking
1 parent bc43df2 commit 679cd8b

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

tools/goctl/api/gogen/sse_handler.tpl

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,11 +30,12 @@ func {{.HandlerName}}(svcCtx *svc.ServiceContext) http.HandlerFunc {
3030
// w.Header().Set("Cache-Control", "no-cache")
3131
// w.Header().Set("Connection", "keep-alive")
3232
client := make(chan {{.ResponseType}}, 16)
33-
defer func() {
34-
close(client)
35-
}()
33+
3634
l := {{.LogicName}}.New{{.LogicType}}(r.Context(), svcCtx)
3735
threading.GoSafeCtx(r.Context(), func() {
36+
defer func() {
37+
close(client)
38+
}()
3839
err := l.{{.Call}}({{if .HasRequest}}&req, {{end}}client)
3940
if err != nil {
4041
logc.Errorw(r.Context(), "{{.HandlerName}}", logc.Field("error", err))
@@ -44,7 +45,10 @@ func {{.HandlerName}}(svcCtx *svc.ServiceContext) http.HandlerFunc {
4445

4546
for {
4647
select {
47-
case data := <-client:
48+
case data, ok := <-client:
49+
if !ok {
50+
return
51+
}
4852
output, err := json.Marshal(data)
4953
if err != nil {
5054
logc.Errorw(r.Context(), "{{.HandlerName}}", logc.Field("error", err))

0 commit comments

Comments
 (0)