Skip to content

Commit 8d327c5

Browse files
milvus: skip retry if server not support get segment info (#730)
Signed-off-by: huanghaoyuanhhy <[email protected]>
1 parent 1c14519 commit 8d327c5

File tree

1 file changed

+17
-25
lines changed

1 file changed

+17
-25
lines changed

core/client/milvus/restful.go

Lines changed: 17 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -203,32 +203,24 @@ func (r *RestfulClient) GetSegmentInfo(ctx context.Context, db string, collID, s
203203
getReq := getSegmentInfoReq{DbName: db, CollectionID: collID, SegmentIDs: []int64{segID}}
204204
var getResp getSegmentInfoResp
205205

206-
err := retry.Do(ctx, func() error {
207-
resp, err := r.cli.R().
208-
SetContext(ctx).
209-
SetBody(getReq).
210-
SetSuccessResult(&getResp).
211-
Post("/v2/vectordb/segments/describe")
212-
if err != nil {
213-
return fmt.Errorf("client: failed to get segment info via restful: %w", err)
214-
}
215-
log.Debug("get segment info via restful", zap.Any("getResp", resp))
216-
if resp.IsErrorState() {
217-
return fmt.Errorf("client: failed to get segment info via restful: %v", resp)
218-
}
219-
220-
if len(getResp.Data.SegmentInfos) == 0 {
221-
return fmt.Errorf("client: no segment info found for segment id %d", segID)
222-
}
223-
if getResp.Code != 0 {
224-
return fmt.Errorf("client: failed to get segment info via restful: %v", getResp)
225-
}
226-
227-
return nil
228-
})
229-
206+
resp, err := r.cli.R().
207+
SetContext(ctx).
208+
SetBody(getReq).
209+
SetSuccessResult(&getResp).
210+
Post("/v2/vectordb/segments/describe")
230211
if err != nil {
231-
return nil, err
212+
return nil, fmt.Errorf("client: failed to get segment info via restful: %w", err)
213+
}
214+
log.Debug("get segment info via restful", zap.Any("getResp", resp))
215+
if resp.IsErrorState() {
216+
return nil, fmt.Errorf("client: failed to get segment info via restful: %v", resp)
217+
}
218+
219+
if len(getResp.Data.SegmentInfos) == 0 {
220+
return nil, fmt.Errorf("client: no segment info found for segment id %d", segID)
221+
}
222+
if getResp.Code != 0 {
223+
return nil, fmt.Errorf("client: failed to get segment info via restful: %v", getResp)
232224
}
233225

234226
return &getResp.Data.SegmentInfos[0], nil

0 commit comments

Comments
 (0)