fix linters and improve tests

Author: aryanmehrotra

configs/.env

@@ -1,3 +1,2 @@
 APP_NAME=static-server
-STATIC_DIR_PATH=
-FILE_NOT_FOUND_PATH=
+STATIC_DIR_PATH=

main.go

@@ -10,13 +10,14 @@ import (
 )
 
 const defaultStaticFilePath = `./static`
-const defaultPathFileNotFound = "/404.html"
+const indexHTML = "/index.html"
+const htmlExtension = ".html"
+const rootPath = "/"
 
 func main() {
 	app := gofr.New()
 
 	staticFilePath := app.Config.GetOrDefault("STATIC_DIR_PATH", defaultStaticFilePath)
-	fileNotFoundPath := app.Config.GetOrDefault("FILE_NOT_FOUND_PATH", defaultPathFileNotFound)
 
 	app.UseMiddleware(func(_ http.Handler) http.Handler {
 		return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
@@ -25,20 +26,17 @@ func main() {
 			// check if the path has a file extension
 			ok, _ := regexp.MatchString(`\.\S+$`, filePath)
 
-			if r.URL.Path == "/" {
-				filePath = "/index.html"
+			if r.URL.Path == rootPath {
+				filePath += indexHTML
 			} else if !ok {
 				if stat, err := os.Stat(filePath); err == nil && stat.IsDir() {
-					filePath = filepath.Join(r.URL.Path, "/index.html")
+					filePath += indexHTML
 				} else {
-					r.URL.Path += ".html"
+					filePath += htmlExtension
 				}
 			}
 
-			filePath = filepath.Join(staticFilePath, r.URL.Path)
 			if _, err := os.Stat(filePath); os.IsNotExist(err) {
-				r.URL.Path = fileNotFoundPath
-
 				w.WriteHeader(http.StatusNotFound)
 
 				filePath = filepath.Join(staticFilePath, "404.html")

main_test.go

@@ -47,7 +47,8 @@ func TestServer(t *testing.T) {
 	}{
 		{"/", http.StatusOK},
 		{"/index", http.StatusOK},
-		{"/index/", http.StatusNotFound},
+		{"/index/", http.StatusOK},
+		{tempDir + "/index.html", http.StatusNotFound},
 		{"/index.html", http.StatusOK},
 		{"/nonexistent", http.StatusNotFound},
 	}