fix completion strategy blocking fallback to history #841
+9
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When completion finds no results, unset suggestion to allow the next strategy to run instead of blocking with the original input text.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
ZSH_AUTOSUGGEST_STRATEGY=(completion history), the completion strategy would prevent fallback to history even when no completions were found. The completion strategy returned the original input as the suggestion when no completions existed, causing the strategy loop to exit early instead of trying the next strategy.I added a check to unset suggestion if it equals the input. Now the history strategy is properly tried when completion finds nothing.