Skip to content

Conversation

hugosolar
Copy link

@hugosolar hugosolar commented Jul 10, 2025

Description of the Change

Adds helper texts to Watson settings as described in #919
Adds helper texts to Threshold % and change label.
Adds a new file to store helper texts

Closes #919 #918 #793

How to test the Change

  • Switch to the feature branch
  • run npm run build
  • Test admin settings screen
  • Language Processing > Classification
    Tooltip
    watson-helper-text

Threshold
classification-display-info

  • Language Processing > Term cleanup
    Threshold
    term-cleanup-screen

  • Language Processing > Moderation

Screenshot 2025-07-14 at 7 38 52 AM

Changelog Entry

Added - New feature

  • Helper texts for Watson settings
  • Helper text for Threshold confidence
  • Helper text for Moderation

Credits

Props @hugosolar

Checklist:

@hugosolar hugosolar self-assigned this Jul 10, 2025
@hugosolar hugosolar requested review from dkotter, jeffpaul and a team as code owners July 10, 2025 19:10
@github-actions github-actions bot added this to the 3.6.0 milestone Jul 10, 2025
@github-actions github-actions bot added the needs:code-review This requires code review. label Jul 10, 2025
@hugosolar hugosolar changed the title Add helper text to watson settings Add helper text to Classification & term cleanup screen Jul 12, 2025
@hugosolar hugosolar changed the title Add helper text to Classification & term cleanup screen Add helper text to Classification, Moderation & term cleanup screen Jul 14, 2025
Copy link
Collaborator

@dkotter dkotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks good to me, nice work here. There are a bunch of eslint errors though that we'll want to get cleaned up before merging this in

@dkotter
Copy link
Collaborator

dkotter commented Jul 14, 2025

Also, worth looking at #953 as it introduces some helper text as well and takes a slightly different approach (modal). We should standardize here so we don't have different approaches for the same thing. I'm okay with either, seems like maybe the modal approach gives us more flexibility though?

@hugosolar
Copy link
Author

@dkotter you're right! I think it gave us more flexibility so I think we should go with that solution instead.
I guess I need to wait until those changes get merged and adding the documentation using that method. does that make sense to you?

@dkotter
Copy link
Collaborator

dkotter commented Jul 15, 2025

@dkotter you're right! I think it gave us more flexibility so I think we should go with that solution instead. I guess I need to wait until those changes get merged and adding the documentation using that method. does that make sense to you?

Yep, makes sense. I think the plan is to create a reusable component in that other PR so hopefully once that's done, it's a fairly easy implementation here

@jeffpaul
Copy link
Member

@hugosolar if you've got continued time, perhaps helping get #953 to done would be great and then we can double back here to update accordingly?

@dkotter dkotter modified the milestones: 3.6.0, 3.7.0 Aug 18, 2025
@dkotter dkotter modified the milestones: 3.7.0, 3.8.0 Sep 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLOCKED needs:code-review This requires code review.
Projects
None yet
3 participants