-
Notifications
You must be signed in to change notification settings - Fork 62
Add helper text to Classification, Moderation & term cleanup screen #957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks good to me, nice work here. There are a bunch of eslint errors though that we'll want to get cleaned up before merging this in
Also, worth looking at #953 as it introduces some helper text as well and takes a slightly different approach (modal). We should standardize here so we don't have different approaches for the same thing. I'm okay with either, seems like maybe the modal approach gives us more flexibility though? |
@dkotter you're right! I think it gave us more flexibility so I think we should go with that solution instead. |
Yep, makes sense. I think the plan is to create a reusable component in that other PR so hopefully once that's done, it's a fairly easy implementation here |
@hugosolar if you've got continued time, perhaps helping get #953 to done would be great and then we can double back here to update accordingly? |
Description of the Change
Adds helper texts to Watson settings as described in #919
Adds helper texts to Threshold % and change label.
Adds a new file to store helper texts
Closes #919 #918 #793
How to test the Change
npm run build
Tooltip
Threshold

Language Processing > Term cleanup

Threshold
Language Processing > Moderation
Changelog Entry
Credits
Props @hugosolar
Checklist: