Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a bug related to null pointer access when dereferencing operation strings in the Analyzer. The fix expands the req_op_str array to properly handle all possible values of the req_op_e enum, preventing potential segmentation faults when accessing invalid operation indices.
Key changes:
- Expands the
req_op_strarray from 16 elements to 257 elements to match the full range ofreq_op_eenum values - Introduces macro definitions to efficiently populate the array with "invalid" strings for undefined operations
Collaborator
Author
|
For this issue, we can either change the value of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Analyzer, we will output op str, the nullptr will cause an error when deref
15 valid str + 242 invalid str