BASIS-556: configure origin and host for access check and bss stats #780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
endryhold
reviewed
Sep 30, 2025
charts/tiles-api/values.yaml
Outdated
| # @param proxy.access.raster.token Service key for raster data in Keys API. Used for key validation. If Keys API is unavailable or token is empty/invalid, tile service will continue to work without key validation (with warning in logs). | ||
| # @param proxy.access.vector.token Service key for vector data in Keys API. Used for key validation. If Keys API is unavailable or token is empty/invalid, tile service will continue to work without key validation (with warning in logs). | ||
|
|
||
| # @extra proxy.access.skipExactOrigins **Exact origins that will skip access key check** |
There was a problem hiding this comment.
В описании переменных не очень понятно поведение. В описании к ПРу прям хорошо расписано. Давай добавим сюда (ко всем переменным, которые принесли) аналогичное описание?
There was a problem hiding this comment.
Поменял описание на более понятно, оно действительно было неочевидно
charts/tiles-api/values.yaml
Outdated
| skipExactOrigins: | ||
| enabled: false | ||
| useDefaultValue: false | ||
| originRegexpPattern: '' |
There was a problem hiding this comment.
Тут помимо описания бы еще пример привести, в каком формате мы ожидаем заголовки
charts/tiles-api/values.yaml
Outdated
|
|
||
| registerExactHosts: | ||
| enabled: false | ||
| useDefaultValue: false |
There was a problem hiding this comment.
А зачем вот эта лишняя логика про дефолт? Вы не можете у себя при деплое просто использовать registerExactHosts.enabled true и registerExactHosts.hostRegexpPattern прописывать сами свое дефолтное значение?
charts/tiles-api/values.yaml
Outdated
|
|
||
| skipExactOrigins: | ||
| enabled: false | ||
| useDefaultValue: false |
There was a problem hiding this comment.
аналогично комменту про дефолт
IgorYurevich
changed the title
added 6 commits
October 3, 2025 12:14
…вки bss статистики в tiles-api
IgorYurevich
force-pushed
the
BASIS-556-configure-origin-and-host-for-access-check-and-bss-stats
branch
from
bcb7a9b to
1b2360c
Compare
charts/tiles-api/values.yaml
Outdated
Comment on lines
248
to
249
| # @extra proxy.access.stat.registerExactHosts **Register requests to BSS for exact hosts feature settings** | ||
| # @param proxy.access.stat.registerExactHosts.enabled If disabled, all requests will be registered in BSS, otherwise the only requests to exact hosts that matches regexp will be registered (hosts of tiles-api). |
There was a problem hiding this comment.
Suggested change
| # @extra proxy.access.stat.registerExactHosts **Register requests to BSS for exact hosts feature settings** | |
| # @param proxy.access.stat.registerExactHosts.enabled If disabled, all requests will be registered in BSS, otherwise the only requests to exact hosts that matches regexp will be registered (hosts of tiles-api). | |
| # @extra proxy.access.stat.registerExactHosts **Register requests to stat-receiver for exact hosts feature settings** | |
| # @param proxy.access.stat.registerExactHosts.enabled If disabled, all requests will be registered in stat-receiver, otherwise the only requests to exact hosts that matches regexp will be registered (hosts of tiles-api). |
There was a problem hiding this comment.
Поправил, спасибо
|
нужно обновить образ, в котором это поддержали |
|
задача на проверку https://jira.2gis.ru/browse/ONPREM-2541 |
…d-bss-stats' of github.com:2gis/on-premise-helm-charts into BASIS-556-configure-origin-and-host-for-access-check-and-bss-stats
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request description
access.skip-exact-origins.enabled, если false - все запросы за векторными, растровыми, mapbox тайлами будут проверяться на ключaccess.skip-exact-origins.regexp-pattern- то запросы с заголовком Origin попадающим под regexp не будет проверяться в сервисе ключейaccess.bss.register-exact-hosts.enabled, если false - все запросы будут регистрироваться в bssaccess.bss.register-exact-hosts.regexp-pattern- то только запросы с host попадающим под regexp будут регистрироваться в bssChangelog
Issues
BASIS-556(https://jira.2gis.ru/browse/BASIS-556)Breaking changes
Check-list. Чек-лист код-ревью
helm lint charts/search-api