-
Notifications
You must be signed in to change notification settings - Fork 10
big-search #794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
big-search #794
Conversation
apiVersion: v2 | ||
name: search-api | ||
description: Search engine for catalog | ||
name: big-search |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
раз уж заменяем чарт, тогда так
name: big-search | |
name: search-api |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Всё таки пришли к такому варианту. Поправлю.
# incremented each time you make changes to the application. Versions are not expected to | ||
# follow Semantic Versioning. They should reflect the version the application is using. | ||
# It is recommended to use it with quotes. | ||
appVersion: "8.14.6" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
appVersion: "8.14.6" | |
appVersion: 8.14.6 |
@@ -0,0 +1,301 @@ | |||
# bluegreen: 'blue' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
это же временный файл? потом уберется?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Это пример с которым я деплоил, который учитывает ваши требования.
Он ужен вам как минимум для первого деплоя, далее могу выпилить.
repository: docker-hub.2gis.ru/usrch/bs-worker | ||
pullPolicy: IfNotPresent | ||
tag: 0.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
имя образа должно отражать имя сервиса, к которому относится и тэги должны быть в semver
repository: docker-hub.2gis.ru/usrch/bs-worker | |
pullPolicy: IfNotPresent | |
tag: 0.1 | |
repository: 2gis-on-premise/search-worker | |
pullPolicy: IfNotPresent | |
tag: 0.1.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
окей переделаю
loggerLevel: "info" | ||
loggerFormat: "json" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
дефолтные строки без кавычек
loggerLevel: "info" | |
loggerFormat: "json" | |
loggerLevel: info | |
loggerFormat: json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Никаких кавычек, понял.
podSecurityContext: {} | ||
securityContext: {} | ||
hpa: | ||
enabled: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hpa, vpa по дефолту отключаем
enabled: true | |
enabled: false |
enabled: true | ||
updateMode: "Off" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
enabled: true | |
updateMode: "Off" | |
enabled: false | |
updateMode: Off |
|
||
ingress: | ||
enabled: false | ||
className: "nginx" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
className: "nginx" | |
className: nginx |
|
||
# @param onpremise Enable specific parameters for on-premise deployment | ||
|
||
onpremise: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
onpremise: false | |
onpremise: true |
bucket: '' | ||
accessKey: '' | ||
secretKey: '' | ||
manifest: '1' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
manifest: '1' | |
manifest: '' |
Pull Request description
Changelog
Большой поиск в On-Prem
(Полностью новый поиск)Issues
Issue-123
(Link to related issue)Breaking changes
Это полностью новое приложение, не знаю на сколько это Breaking-Changes, на 0 или на 100%.
Check-list. Чек-лист код-ревью
helm lint charts/search-api