Skip to content

Conversation

zhukov-d-man
Copy link
Collaborator

Pull Request description

Changelog

  • Большой поиск в On-Prem (Полностью новый поиск)

Issues

  • Issue-123 (Link to related issue)

Breaking changes

  • If there are breaking changes, they need to be added to the file Breaking-Changes
    Это полностью новое приложение, не знаю на сколько это Breaking-Changes, на 0 или на 100%.

Check-list. Чек-лист код-ревью

  • Запрос на слияние в develop.
  • Есть описание к PR.
  • Указаны блокирующие изменения. Breaking-Changes
  • Соответствие кода принятому стилю
    • Описание настроек.
    • Именование настроек.
    • Дефолтные значения.
    • Стиль кода.
  • Работоспособность. Разворачивается на своем окружении из ветки PR.
    • Тест API через тесты helmfile-хуков или коллекций Postman.
  • Не осталось мусора от удаления каких-то параметров. Ищется поиском по проекту из ветки PR.
  • Отработка линтера на чарт из ветки PR. Пример: helm lint charts/search-api

@zhukov-d-man zhukov-d-man requested review from a team as code owners October 6, 2025 10:13
apiVersion: v2
name: search-api
description: Search engine for catalog
name: big-search
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

раз уж заменяем чарт, тогда так

Suggested change
name: big-search
name: search-api

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Всё таки пришли к такому варианту. Поправлю.

# incremented each time you make changes to the application. Versions are not expected to
# follow Semantic Versioning. They should reflect the version the application is using.
# It is recommended to use it with quotes.
appVersion: "8.14.6"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
appVersion: "8.14.6"
appVersion: 8.14.6

@@ -0,0 +1,301 @@
# bluegreen: 'blue'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

это же временный файл? потом уберется?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Это пример с которым я деплоил, который учитывает ваши требования.
Он ужен вам как минимум для первого деплоя, далее могу выпилить.

Comment on lines +109 to +111
repository: docker-hub.2gis.ru/usrch/bs-worker
pullPolicy: IfNotPresent
tag: 0.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

имя образа должно отражать имя сервиса, к которому относится и тэги должны быть в semver

Suggested change
repository: docker-hub.2gis.ru/usrch/bs-worker
pullPolicy: IfNotPresent
tag: 0.1
repository: 2gis-on-premise/search-worker
pullPolicy: IfNotPresent
tag: 0.1.0

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

окей переделаю

Comment on lines +115 to +116
loggerLevel: "info"
loggerFormat: "json"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

дефолтные строки без кавычек

Suggested change
loggerLevel: "info"
loggerFormat: "json"
loggerLevel: info
loggerFormat: json

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Никаких кавычек, понял.

podSecurityContext: {}
securityContext: {}
hpa:
enabled: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hpa, vpa по дефолту отключаем

Suggested change
enabled: true
enabled: false

Comment on lines +1573 to +1574
enabled: true
updateMode: "Off"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
enabled: true
updateMode: "Off"
enabled: false
updateMode: Off


ingress:
enabled: false
className: "nginx"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
className: "nginx"
className: nginx


# @param onpremise Enable specific parameters for on-premise deployment

onpremise: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
onpremise: false
onpremise: true

bucket: ''
accessKey: ''
secretKey: ''
manifest: '1'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
manifest: '1'
manifest: ''

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants