Fix: correct JSON parsing in AdminEReportingHeaderController to handle ArrayNode properly#1596
Open
Manas-Dikshit wants to merge 1 commit into52North:developfrom
Open
Fix: correct JSON parsing in AdminEReportingHeaderController to handle ArrayNode properly#1596Manas-Dikshit wants to merge 1 commit into52North:developfrom
Manas-Dikshit wants to merge 1 commit into52North:developfrom
Conversation
Updated JSON handling in save method to correctly process report obligations as an array.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Correct JSON parsing in
AdminEReportingHeaderControllerThe
save()method incorrectly treatedreportObligationsas an object usingfieldNames(),while
getJSON()encodes it as an array. This caused obligations to not be saved properly.Before:
After:
Properly iterates over ArrayNode
Adds null/invalid ID checks and logging
Fixes data not being persisted during POST
Result: Controller now correctly saves all reporting obligations with stable JSON decoding.