Skip to content

refactor: consolidate geometry assertions and improve test robustness…#136

Open
kashi-verma wants to merge 1 commit into52North:mainfrom
kashi-verma:patch-1
Open

refactor: consolidate geometry assertions and improve test robustness…#136
kashi-verma wants to merge 1 commit into52North:mainfrom
kashi-verma:patch-1

Conversation

@kashi-verma
Copy link

… in TestDPM

Refactor geometry assertions into a private helper method _assert_geometry.

Fix off-by-one error in test_get_apparent_wind loop.

Update floating-point assertions to use pytest.approx for clearer intent.

Standardize string formatting to f-strings across the test suite.

Related Issue / Discussion:

Please delete the option which is not relevant.

Fixes Issue #XX

Relates to discussion [link]

Changes:

Please list the central functionalities that have been changed:

  • New class / file / …
  • Modified class / file / …

Further Details:

Summary:

Please mention the relevant motivation and context of your changes and shortly describe the behaviour before and after your modifications.

Dependencies:

Please list new dependencies that are required for this modification.

PR Checklist:

In the context of this PR, I:

Please consider that PRs which do not meet the requirements specified in the checklist will not be evaluated. Also, PRs with no activities will be closed after a reasonable amount of time.

… in TestDPM

Refactor geometry assertions into a private helper method _assert_geometry.

Fix off-by-one error in test_get_apparent_wind loop.

Update floating-point assertions to use pytest.approx for clearer intent.

Standardize string formatting to f-strings across the test suite.
@kdemmich
Copy link
Collaborator

Hi @kashi-verma , thank you for your PR. We appreciate the time and effort that was put into it but, unfortunately, you did not fill important section of our PR template. We will not evaluate PRs that do not follow our PR template.

@kdemmich kdemmich added the question Further information is requested label Feb 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

question Further information is requested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants