Fix: Sort observations by resultTime in descending order#19
Open
ram-from-tvl wants to merge 1 commit into52North:mainfrom
Open
Fix: Sort observations by resultTime in descending order#19ram-from-tvl wants to merge 1 commit into52North:mainfrom
ram-from-tvl wants to merge 1 commit into52North:mainfrom
Conversation
Resolves 52North#5 - Observations are now returned sorted by resultTime DESC, ensuring newest observations appear first for consistent pagination.
There was a problem hiding this comment.
Pull request overview
This pull request adds sorting functionality to observation queries by implementing an ORDER BY resulttime DESC clause at the database level. The change addresses issue #5, which reported that observations were being returned in an unsorted order, making it difficult for API consumers to work with time-series data predictably.
Changes:
- Added
ORDER BY resulttime DESCto the SQL query builder inObservationQuery.to_sql()method to ensure all observation queries return results sorted by newest first
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5
Changes Made
Added
ORDER BY resulttime DESCclause to the SQL query in theObservationQuery.to_sql()method (util.py).This ensures observations are returned in descending order by
resultTime, with the newest observations appearing first.Why This Approach
resultTimeas the sort key aligns with the observation data modelORDER BYclause is placed beforeLIMIT/OFFSETto ensure proper paginationResolves #5