Skip to content

requireFromString may return a promise Observed in webpack 5. #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −4
Open

requireFromString may return a promise Observed in webpack 5. #122

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,11 +58,11 @@ function getFilename(serverStats, outputPath, chunkName) {
);
}

function getServerRenderer(filename, buffer, options) {
async function getServerRenderer(filename, buffer, options) {
const errMessage = `The 'server' compiler must export a function in the form of \`(options) => (req, res, next) => void\``;

let serverRenderer = interopRequireDefault(
requireFromString(buffer.toString(), filename)
await requireFromString(buffer.toString(), filename)
);
if (typeof serverRenderer !== 'function') {
throw new Error(errMessage);
Expand Down Expand Up @@ -128,7 +128,7 @@ function webpackHotServerMiddleware(multiCompiler, options) {
let serverRenderer;
let error = false;

const doneHandler = (multiStats) => {
const doneHandler = async (multiStats) => {
error = false;

const serverStats = findStats(multiStats, 'server')[0];
Expand Down Expand Up @@ -156,7 +156,7 @@ function webpackHotServerMiddleware(multiCompiler, options) {
serverStats: serverStats.toJson()
}, options.serverRendererOptions);
try {
serverRenderer = getServerRenderer(filename, buffer, serverRendererOptions);
serverRenderer = await getServerRenderer(filename, buffer, serverRendererOptions);
} catch (ex) {
debug(ex);
error = ex;
Expand Down