acmego: fix line deletions at beginning of a file#128
Open
chressie wants to merge 1 commit into9fans:mainfrom
Open
acmego: fix line deletions at beginning of a file#128chressie wants to merge 1 commit into9fans:mainfrom
chressie wants to merge 1 commit into9fans:mainfrom
Conversation
If the formatter deletes 1 (or more) lines in the beginning of a file, the corresponding diff output records this with for example "1d0". Until now, the trailing "0" tripped off the logic and the code just didn't apply such a deletion. This is now fixed by ignoring the trailing "0" for line deletion markers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the formatter deletes 1 (or more) lines in the beginning of a file, the corresponding diff output records this with for example "1d0".
Until now, the trailing "0" tripped off the logic and the code just didn't apply such a deletion. This is now fixed by ignoring the trailing "0" for line deletion markers.