Add support for musig2 #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sstone
force-pushed
the
snapshot/musig2
branch
2 times, most recently
from
fd246e9 to
581c617
Compare
sstone
force-pushed
the
snapshot/musig2
branch
4 times, most recently
from
951c843 to
962cefb
Compare
sstone
force-pushed
the
snapshot/musig2
branch
2 times, most recently
from
9ed75a4 to
0c79edd
Compare
t-bast
reviewed
Jan 19, 2024
sstone
force-pushed
the
snapshot/musig2
branch
from
0c79edd to
a3355d2
Compare
This was referenced Jan 22, 2024
sstone
force-pushed
the
snapshot/musig2
branch
from
7b9c200 to
f5219aa
Compare
t-bast
reviewed
Jan 23, 2024
Member
t-bast
left a comment
t-bast
left a comment
There was a problem hiding this comment.
LGTM, once the secp256k1 PR is merged we should be good to go 👍
Usage of the Musig2 functions isn't intuitive at all, especially with the key aggregation cache and session data. It's important to provide accurate documentation to help users understand how to correctly produce musig2 signatures. We also change argument names to match Kotlin best practices instead of using the same argument names as C functions.
sstone
force-pushed
the
snapshot/musig2
branch
from
f5219aa to
0976292
Compare
t-bast
reviewed
Feb 14, 2024
t-bast
approved these changes
Feb 14, 2024
| allprojects { | ||
| group = "fr.acinq.secp256k1" | ||
| version = "0.14.0-SNAPSHOT" | ||
| version = "0.14.0-MUSIG2-SNAPSHOT" |
Member
There was a problem hiding this comment.
This isn't necessary anymore, is it? We'll even change this to 0.14.0 for the release, right? We can change that in a release PR though that sets it explicitly to 0.14.0.
Member
Author
There was a problem hiding this comment.
Yes I'll release version 0.14.0 as soon as the PR is merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use https://github.com/jonasnick/secp256k1/tree/musig2-module instead of https://github.com/bitcoin-core/secp256k1, we'll switch back to
secp256k1once the musig2 module has been included.This branch is based on https://github.com/ACINQ/secp256k1-kmp/tree/snapshot/kotlin-1.9 because it's extremely tedious to work with kotlin's c-interop on kotlin 1.8 but changes could easily be backported if needed before we upgrade.
This PR "tracks" bitcoin-core/secp256k1#1479 and should be ready very soon once it has been merged.