Skip to content

Add option to start test_batch in train_rl from a specific index, also add default tokenizer_path for default model#3419

Open
A9isha wants to merge 1 commit intomainfrom
anisha-test-batch-start
Open

Add option to start test_batch in train_rl from a specific index, also add default tokenizer_path for default model#3419
A9isha wants to merge 1 commit intomainfrom
anisha-test-batch-start

Conversation

@A9isha
Copy link
Collaborator

@A9isha A9isha commented Mar 14, 2026

Description

Add an option for the test dataset to start at a specifiable index instead of always starting at 0 in train_rl.py.

Also, adding the MaxText default model to HF_IDS in src/maxtext/utils/globals.py so that it doesn't raise warning about tokenizer_path during vllm_config creation in train_rl.py

Notice 1: Once all tests pass, the "pull ready" label will automatically be assigned.
This label is used for administrative purposes. Please do not add it manually.

Notice 2: For external contributions, our settings currently require an approval from a MaxText maintainer to trigger CI tests.

Tests

CI and also ran locally on v5p-8

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

…o add default tokenizer_path for default model
@codecov
Copy link

codecov bot commented Mar 14, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/maxtext/trainers/post_train/rl/train_rl.py 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant