-
Notifications
You must be signed in to change notification settings - Fork 497
Fix duplicate logger initialization in images util #884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix duplicate logger initialization in images util #884
Conversation
📝 WalkthroughWalkthroughRemoved a duplicate logger initialization and unused Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
96dcc4d to
5a56fff
Compare
|
I mistakenly removed the logger initialization in the previous commit. I’ve now corrected this to use only the project-level get_logger with a clarifying comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
backend/app/utils/images.py (1)
5-5: Remove the unusedloggingimport.Issue #815 explicitly requires removing the unused
loggingimport along with the duplicate logger initialization. Theloggingmodule is not used anywhere in this file after the duplicate initialization was removed.🔎 Proposed fix
-import logging
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
backend/app/utils/images.py
🔇 Additional comments (1)
backend/app/utils/images.py (1)
23-24: LGTM! Correct logger setup retained.The project-level logger setup using
get_logger(__name__)is correctly retained, ensuring consistent logging configuration with proper color formatting, component prefixes, and environment-based settings. The added comment helps document the rationale for future maintainers.
Fixes #815
Removes duplicate logger initialization in backend/app/utils/images.py to ensure consistent logging configuration.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.