-
Notifications
You must be signed in to change notification settings - Fork 497
fix/684-remove duplicate Home tab and fix navbar height #899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix/684-remove duplicate Home tab and fix navbar height #899
Conversation
📝 WalkthroughWalkthroughUpdated landing-page dependencies, refactored the Demo marquee to duplicate items for seamless scrolling with adjusted animation and styling, and modified mkdocs configuration to disable navigation tabs and adjust the swagger-ui-tag setting. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
Pre-merge checks❌ Failed checks (2 warnings, 1 inconclusive)
✅ Passed checks (2 passed)
📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🔇 Additional comments (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
landing-page/package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (3)
landing-page/package.jsonlanding-page/src/Pages/Demo/marqu.tsxmkdocs.yml
🔇 Additional comments (7)
mkdocs.yml (2)
13-13: Correct fix for duplicate "Home" issue.Disabling
navigation.tabsis the appropriate solution when only one top-level navigation section exists. Material for MkDocs would render a redundant tabs bar showing "Home" when this feature is enabled, creating the duplicate entry described in issue #684.
40-40: Uncomment the swagger-ui-tag plugin instead of removing it.The plugin is already listed in both
docs/requirements.txtandbackend/requirements.txt(version 0.7.1) and is actively used indocs/backend/backend_python/api.mdfor rendering the OpenAPI documentation via<swagger-ui src="openapi.json"/>. Commenting it out breaks the API documentation feature. Change line 40 from:# - swagger-ui-tag: # Commented out to fix plugin not installed error during mkdocs serveto:
- swagger-ui-tagLikely an incorrect or invalid review comment.
landing-page/src/Pages/Demo/marqu.tsx (4)
11-12: Good approach for seamless infinite scrolling.Creating 10 repetitions of the technologies array ensures smooth, gap-free marquee animation across different screen sizes. The implementation is clean and the comment clearly explains the intent.
26-28: Key generation is correct.The composite key
${index}-${tech.text}ensures uniqueness. While index alone would be sufficient here (since the array is static and order never changes), the composite approach doesn't cause issues and provides additional clarity.
29-38: Enhanced styling and interactions improve UX.The updated styling adds visual polish with borders, shadows, and hover effects. Dark mode support is properly implemented, and the framer-motion interactions (hover scale, tap feedback) provide good user feedback.
39-39: Appropriate spacing adjustment.Increasing the separator spacing from
mx-3tomx-6provides better visual balance with the enhanced pill styling.landing-page/package.json (1)
20-20: Verify the framer-motion update doesn't introduce regressions.The patch version bump from 12.23.12 to 12.23.26 should be backward compatible. However, given that the marquee component uses this library extensively, ensure the updated animations work as expected across different browsers and screen sizes.
62fef62 to
6f17d8e
Compare
|
@harshentau-spec assign this issue to me. |
Thanks for reviewing! I’ve tested the changes locally and everything works as expected. Ready for merge once approved. |
Problem
Root Cause
Material for MkDocs was rendering a redundant top tabs bar (
navigation.tabs) even though there's only one top-level section ("Home").Fix
navigation.tabsfeature by commenting it outswagger-ui-tagplugin to allow localmkdocs serveResult
mkdocs serve— works perfectlyCloses #684
Screen.Recording.2026-01-01.133128.mp4
Summary by CodeRabbit
Bug Fixes
Chores
✏️ Tip: You can customize this high-level summary in your review settings.