Skip to content

Update launch_utils.py #16787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
+5 −3
Open

Update launch_utils.py #16787

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions modules/launch_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,8 @@ def run_git(dir, name, command, desc=None, errdesc=None, custom_env=None, live:


def git_clone(url, dir, name, commithash=None):
# TODO clone into temporary dir and move if successful
# Clone into a temporary directory
temp_dir = dir + "_temp"

if os.path.exists(dir):
if commithash is None:
Expand All @@ -187,9 +188,10 @@ def git_clone(url, dir, name, commithash=None):
return

try:
run(f'"{git}" clone --config core.filemode=false "{url}" "{dir}"', f"Cloning {name} into {dir}...", f"Couldn't clone {name}", live=True)
run(f'"{git}" clone --config core.filemode=false "{url}" "{temp_dir}"', f"Cloning {name} into {temp_dir}...", f"Couldn't clone {name}", live=True)
shutil.move(temp_dir, dir) # Move temp directory to final directory
except RuntimeError:
shutil.rmtree(dir, ignore_errors=True)
shutil.rmtree(temp_dir, ignore_errors=True)
raise

if commithash is not None:
Expand Down
Loading