[cuegui] Add email notifications for subscription size/burst changes #2046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonfigueiredo
requested review from
DiegoTavares and
lithorus
as code owners
Added email notifications to track subscription modifications in the CueCommander GUI. When a subscription's size or burst value is changed, an automated email is sent to configured recipients with details about the change, including:
- What was changed (size or burst)
- Old and new values
- Who made the change
- Timestamp of the change
Key features:
- Configurable CC recipients via cuegui.yaml
- Support for email templates with {show} and {domain} placeholders
- Disabled by default (set email.subscription_change_cc to enable)
- Graceful error handling - email failures don't block subscription changes
Configuration:
- New setting: email.subscription_change_cc in cuegui.yaml
- Example: "{show}-admin@{domain},resource-team@{domain}"
Files modified:
- cuegui/config/cuegui.yaml: Added email.subscription_change_cc config
- cuegui/Constants.py: Added SUBSCRIPTION_CHANGE_CC_TEMPLATE constant
- cuegui/MenuActions.py: Implemented _sendSubscriptionChangeEmail() and updated editSize() and editBurst() methods
ramonfigueiredo
force-pushed
the
feature/subscription-change-email-notifications
branch
from
7cd1516 to
cdbc9ce
Compare
Collaborator
Author
|
@DiegoTavares / @lithorus |
Collaborator
|
Isn't it better to have emails sent throught cuebot instead, similar to other emails sent? |
Collaborator
DiegoTavares
left a comment
DiegoTavares
left a comment
There was a problem hiding this comment.
Given that pycue could be used to update subscriptions without cuegui, wouldn't it make more sense to handle email notifications on Cuebot?
Collaborator
Author
|
Thanks @DiegoTavares / @lithorus I will move the email handling to the Cabot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link the Issue(s) this Pull Request is related to.
Summarize your change.
Added email notifications to track subscription modifications in the CueCommander GUI. When a subscription's size or burst value is changed, an automated email is sent to configured recipients with details about the change, including:
Key features:
Configuration:
Files modified: