Add Basic File Operations to the RVFileDialog #851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- available in context menu - create folders - delete files - rename files - refresh Signed-off-by: Mark Reid <[email protected]>
markreidvfx
requested review from
bernie-laberge,
cedrik-fuoco-adsk and
eloisebrosseau
as code owners
eloisebrosseau
approved these changes
Aug 1, 2025
pbergeron-adsk
approved these changes
Sep 17, 2025
Contributor
pbergeron-adsk
left a comment
pbergeron-adsk
left a comment
There was a problem hiding this comment.
LGTM, will submit to view testing.
bernie-laberge
approved these changes
Sep 17, 2025
Contributor
bernie-laberge
left a comment
bernie-laberge
left a comment
There was a problem hiding this comment.
Beautiful !
Thank you @markreidvfx !
Contributor
|
@markreidvfx We have found two issues with this PR: Issue 1:
Note that if you don't select FolderABC first, the bug doesn't appear. Expected result: User should stay in FolderRoot, optionally goes to FolderDEF, but definitely not FolderABC. Issue 2:
but
They are probably different manifestations of the same bug (I'd expect that when you click on a folder, that sets the "current folder", and when you're done creating a folder, it calls refresh, which navigates to the previously-selected folder) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summarize your change.
Adds support for basic file operations within the
RVFileDialogwindow. Please note I've not had time to test this on Windows.Adds a context menu with the following options
New folder button
The
New Folderbutton was already in the ui files. It was just hidden because it was never implementedDescribe what you have tested and on which operating system.
Linux, macOS