Skip to content

Conversation

@BelKed
Copy link
Contributor

@BelKed BelKed commented Mar 1, 2025


Important

Enable persistent background scripts for Firefox by setting {{firefox}}.persistent to true in manifest.json.

This description was created by Ellipsis for 8037072. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 8037072 in 5 minutes and 21 seconds

More details
  • Looked at 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. src/manifest.json:24
  • Draft comment:
    Persistent background script flag set to true for Firefox. Confirmed this resolves the issue with tracking after prolonged use. Be cautious of potential increased resource usage.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50%
    None
2. src/manifest.json:24
  • Draft comment:
    Setting persistent to true for Firefox looks correct to enable continuous background tracking.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50%
    None

Workflow ID: wflow_dNd34HFOJewJDXPY


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@ErikBjare
Copy link
Member

I guess #153 wasn't good after all 😅

@BelKed
Copy link
Contributor Author

BelKed commented Mar 1, 2025

During normal use it worked fine, but during long AFK sessions it tended to stop recording after a while :/
I only tested normal use at the time...

@BelKed
Copy link
Contributor Author

BelKed commented Mar 2, 2025


Seems to be working fine after changing persistent to true :)

@ErikBjare ErikBjare merged commit f7860a8 into ActivityWatch:master Mar 2, 2025
5 checks passed
@BelKed BelKed deleted the enable-persistent branch March 12, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Browsing data from Firefox isn't tracked properly

2 participants