Add full tests for Color and Swatch classes #259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bheston
force-pushed
the
users/bheston/adaptive-ui-color-tests
branch
from
c934a7a to
4782c35
Compare
nicholasrice
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Adding tests for all static and instance functions available on
ColorandSwatch.Aside from having good tests, my motivation for this is for some refactoring work involving these classes. I want to make sure the resultant interfaces are equivalent but deprecated where necessary.
Test Plan
Ran tests.
Checklist
General
⏭ Next Steps
As mentioned, I have some follow-up work to address some renaming and allow for new color features.