Feature/Add pagination #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+28
to
+41
|
|
||
| test('fetch more data when scrolled down', async function(assert) { | ||
| await page.visit(); | ||
|
|
||
| assert.equal(page.books().count, 9); | ||
|
|
||
| document.querySelector(page.loaderClass).scrollIntoView(); | ||
|
|
||
| await waitUntil(() => { | ||
| return page.books().count === 18; | ||
| }); | ||
|
|
||
| assert.equal(page.books().count, 18); | ||
| }); |
There was a problem hiding this comment.
The tests seem to use the actual api, meaning that they will hit the api every time the test runs.
Can you think of why this might not be a good idea in real live app and what are some alternatives?
Comment on lines
-17
to
28
|
|
||
| return this.store.query('book', { | ||
| page: { | ||
| size: ENV.BOOKS_PER_PAGE, | ||
| }, | ||
| return this.infinity.model('book', { | ||
| filter: { | ||
| 'author.name': query | ||
| }, | ||
| include: 'author,photos' | ||
| include: 'author,photos', | ||
| perPage: ENV.BOOKS_PER_PAGE, | ||
| startingPage: 1, | ||
| perPageParam: 'page[size]', | ||
| pageParam: 'page[number]', | ||
| countParam: 'meta.total_resources' | ||
| }); |
There was a problem hiding this comment.
This looks very similar with a query made in the books, maybe we can find a way to remove duplication.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We've added infinity scroll pagination on elements and fixed the bug with the broken images. We replaced them with a static placeholder image.