fix(mjpeg): correct dimension clamping and add EOI bounds guard#2190
Open
MechanicalCoderX wants to merge 1 commit intoAlexxIT:masterfrom
Open
fix(mjpeg): correct dimension clamping and add EOI bounds guard#2190MechanicalCoderX wants to merge 1 commit intoAlexxIT:masterfrom
MechanicalCoderX wants to merge 1 commit intoAlexxIT:masterfrom
Conversation
w &= 3 and h &= 3 kept only the low 2 bits instead of rounding down to the nearest multiple of 4. For example, a 1921-pixel-wide frame would be encoded with width=1 rather than width=1920, producing a corrupt or zero-size RTP packet. The correct operator is &^= 3 (bit-clear), which zeroes the low two bits. Also guard the JPEG EOI check with len(buf) >= 2 before indexing the last two bytes, preventing a panic on a malformed/empty frame.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
w &= 3andh &= 3kept only the low 2 bits instead of rounding down to the nearest multiple of 4. A 1921-pixel-wide frame would be encoded with width=1 rather than width=1920, producing a corrupt RTP packet. The correct operator is&^= 3(bit-clear).Also guard the JPEG EOI check with
len(buf) >= 2before indexing the last two bytes, preventing a panic on a malformed or empty frame.