fix(mp4): guard against zero timeScale to prevent +Inf timestamp corruption#2192
Open
MechanicalCoderX wants to merge 1 commit intoAlexxIT:masterfrom
Open
fix(mp4): guard against zero timeScale to prevent +Inf timestamp corruption#2192MechanicalCoderX wants to merge 1 commit intoAlexxIT:masterfrom
MechanicalCoderX wants to merge 1 commit intoAlexxIT:masterfrom
Conversation
…uption When an mdhd atom reported timeScale=0, Probe stored the result of float32(codec.ClockRate)/float32(0) = +Inf in the timeScales map. Demux's existing guard `if timeScale == 0` does not catch +Inf, so subsequent packet timestamps were computed as uint32(float32(ts) * +Inf) = 0, corrupting every packet in the track. Adding `&& timeScale > 0` to the codec registration condition skips tracks with an invalid timescale entirely instead of storing a bad value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an
mdhdatom reportstimeScale=0,Probestoredfloat32(codec.ClockRate)/float32(0) = +Infin the timeScales map.Demux's existing guardif timeScale == 0does not catch+Inf, so subsequent packet timestamps were computed asuint32(float32(ts) * +Inf) = 0, corrupting every packet in the track.Adding
&& timeScale > 0to the codec registration condition skips tracks with an invalid timescale instead of storing a bad value.