chore: update @arcadeai/design-system to latest#848
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
f2a373e to
ddbd578
Compare
|
@teallarson what are we doing about this blog post moving? |
Co-authored-by: jottakka <203343514+jottakka@users.noreply.github.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: Refactoring left
buildScopeDisplayItemsas orphaned dead code- Removed the duplicate buildScopeDisplayItems from available-tools-filter.ts and imported the original exported function from available-tools-table.tsx instead.
Or push these changes by commenting:
@cursor push b2730d4395
Preview (b2730d4395)
diff --git a/app/_components/toolkit-docs/components/available-tools-filter.ts b/app/_components/toolkit-docs/components/available-tools-filter.ts
--- a/app/_components/toolkit-docs/components/available-tools-filter.ts
+++ b/app/_components/toolkit-docs/components/available-tools-filter.ts
@@ -1,5 +1,5 @@
import type { AvailableToolsTableProps, BehaviorFlagKey } from "../types";
-import { normalizeScopes } from "./scopes-display";
+import { buildScopeDisplayItems } from "./available-tools-table";
export type AvailableToolsFilter =
| "all"
@@ -13,10 +13,6 @@
behaviorFlags?: Partial<Record<BehaviorFlagKey, boolean>>;
};
-function buildScopeDisplayItems(scopes: string[]): string[] {
- return normalizeScopes(scopes);
-}
-
function matchesFilterCategory(
tool: AvailableToolsTableProps["tools"][number],
filter: AvailableToolsFilter
diff --git a/app/_components/toolkit-docs/components/available-tools-table.tsx b/app/_components/toolkit-docs/components/available-tools-table.tsx
--- a/app/_components/toolkit-docs/components/available-tools-table.tsx
+++ b/app/_components/toolkit-docs/components/available-tools-table.tsx
@@ -27,7 +27,10 @@
BehaviorFlagKey,
SecretType,
} from "../types";
-import { filterTools } from "./available-tools-filter";
+import {
+ type AvailableToolsFilter,
+ filterTools,
+} from "./available-tools-filter";
import { normalizeScopes } from "./scopes-display";
export {|
|
||
| function buildScopeDisplayItems(scopes: string[]): string[] { | ||
| return normalizeScopes(scopes); | ||
| } |
There was a problem hiding this comment.
Refactoring left buildScopeDisplayItems as orphaned dead code
Low Severity
The extraction of filter logic into available-tools-filter.ts created a new private buildScopeDisplayItems function, but the original exported buildScopeDisplayItems in available-tools-table.tsx was left behind. Its only caller (matchesFilterCategory) was moved to the new file, making it dead code. No file in the codebase imports buildScopeDisplayItems from available-tools-table.tsx. The new file could import and reuse the existing exported function instead of duplicating it.



This PR updates
@arcadeai/design-systemto the latest published version.It runs a design-system compatibility test gate before opening this PR.
If that gate fails, the workflow stops and no PR is created.
workflow_dispatchNote
Medium Risk
Moderate risk due to the
@arcadeai/design-systemupgrade and refactoring of tool filtering/service-domain helpers that could subtly change toolkit docs UI behavior. Changes are localized and now covered by new unit tests for the extracted helpers.Overview
Updates
@arcadeai/design-systemfrom^3.30.0to^3.32.0.Refactors toolkit docs by extracting
filterTools(plusAvailableToolsFilter/options) intoavailable-tools-filter.tsand extractinggetSharedServiceDomainintotoolkit-page-utils.ts, with both utilities re-exported from their previous modules. Adds Vitest coverage for the new filter behavior (operations + behavior flags) and shared service-domain detection.Written by Cursor Bugbot for commit a7b9444. This will update automatically on new commits. Configure here.