fix: do not remove endpoint prefix before /v1/traces
#10417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
Contributor
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Contributor
|
@soapun Thanks for your contribution. Can you please sign the CLA? |
Contributor
|
@soapun thanks so much for the contribution! please add the same endpoint prefix preserving logic to |
anticorrelator
requested changes
Dec 2, 2025
| Returns: | ||
| ParseResult: Modified endpoint with "/v1/traces" path. | ||
| """ | ||
| return parsed_endpoint._replace(path="/v1/traces") |
Contributor
There was a problem hiding this comment.
The same logic should be added to _construct_grpc_endpoint
Contributor
Author
There was a problem hiding this comment.
_construct_grpc_endpoint overwrites port even if it was specified in url, which can also be a bit misleading.
Maybe add something like:
def _construct_grpc_endpoint(parsed_endpoint: ParseResult) -> ParseResult:
return parsed_endpoint._replace(netloc=f"{parsed_endpoint.hostname}:{parsed_endpoint.port or get_env_grpc_port()}")?
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
anticorrelator
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #10416
Note
Avoids stripping existing path prefixes when building HTTP
/v1/tracesendpoints and adds tests to validate behavior.phoenix/otel/otel.py_construct_http_endpointto preserve existing path prefixes if the URL already ends with/v1/traces; otherwise appends the traces path.tests/test_settings.pyfor_construct_http_endpoint, covering base URL, already-suffixed URL, and prefixed path cases.Written by Cursor Bugbot for commit 1015813. This will update automatically on new commits. Configure here.