Skip to content

Conversation

Umeaboy
Copy link

@Umeaboy Umeaboy commented Mar 12, 2024

No description provided.

Signed-off-by: Kristoffer Grundström <[email protected]>
@leio
Copy link

leio commented Mar 12, 2024

fwiw, to save git blame time for others - this was added like this in commit dcdd195

Copy link
Member

@davide125 davide125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Signed-off-by tag is wrong on this commit (the email doesn't match the commit author one)

Signed off by: Kristoffer Grundström <[email protected]>
@Umeaboy
Copy link
Author

Umeaboy commented Apr 16, 2025

Is it OK now with my 2nd commit?

@Umeaboy Umeaboy requested a review from davide125 April 16, 2025 22:44
Signed-off-by: Kristoffer Grundström <[email protected]>
@Umeaboy
Copy link
Author

Umeaboy commented Apr 16, 2025

I saw my spelling error. Sorry!!!!!

Copy link
Member

@davide125 davide125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend using git commit -s instead of adding the tag by hand, that should prevent issues like this. You will also need to squash this to a single commit (e.g. with git rebase and then a force push) or the DCO check won't pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants