Move slit to MICADO.yaml; general spec mode#308
Merged
oczoske merged 7 commits intodev_masterfrom Apr 9, 2026
Merged
Conversation
Contributor
|
I suggest adding sub_pixel:
flag: Trueto the While not strictly related to the rest of this PR, it seems like a useful default and doesn't appear to impact performance too badly, at least on my machine... |
Contributor
Author
|
Sorry for all those commits (from rebasing dev_master). The relevant commits for this PR are the first ones up to 5b96512 ("New notebook...") |
initialise OBS.slit to false for imaging dark adjusted; sub_pixel True; minor changes
teutoburg
approved these changes
Apr 8, 2026
Contributor
teutoburg
left a comment
There was a problem hiding this comment.
Fixed the rebase accident as discussed through other means of communication. Ready to merge for me.
janusbrink
suggested changes
Apr 9, 2026
Contributor
janusbrink
left a comment
There was a problem hiding this comment.
Thanks - this looks great. The pipeline relies on slit names "Long/Short/Wide" (and their pinhole/shifted variants) - so best to change the files/names to match before merging this change?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MICADO slit selection is moved to
MICADO.yamlin the form of aSlitWheel:A new mode
SPECis introduced, which replaces all current spectroscopic modes. The old modesSPEC_15000x20etc. still exist and should work as before with default settings as indicated by their name.FITS keyword
INS.SLIT.NAMEis updated when the slit is changed. As the pipeline relies on the names being "Short", "Wide", "Long", the slit definition files are renamed accordingly:Again, the old modes keep their name.
A new notebook demonstrating the new slit mode has been added to
MICADO/docs/extra_notebooks. Maybe this could be integrated with6_basic_spectroscopy.ipynb, but I'll leave it stand-alone for now. Notebooks in the new directoryextra_notebooksare not automatically run by github actions.Needs AstarVienna/ScopeSim#875
Closes #88