Skip to content

Conversation

@pgr0ss
Copy link
Contributor

@pgr0ss pgr0ss commented Oct 30, 2025

📑 Description

This lets these tools use a float window instead of a small split at the bottom of the screen, and is how lazygit is currently used in AstroNvim:

https://github.com/AstroNvim/AstroNvim/blob/0001b5adbd6b6b9c14166f5c5955c43fde5624de/lua/astronvim/plugins/toggleterm.lua#L18

📖 Additional Information

Before:
Screenshot 2025-10-30 at 9 55 56 AM

After:

Screenshot 2025-10-30 at 9 55 14 AM

This lets these tools use a float window instead of a small split at the
bottom of the screen, and is how `lazygit` is currently used in AstroNvim:

https://github.com/AstroNvim/AstroNvim/blob/0001b5adbd6b6b9c14166f5c5955c43fde5624de/lua/astronvim/plugins/toggleterm.lua#L18
@github-actions
Copy link

github-actions bot commented Oct 30, 2025

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Entry returns a single plugin spec with the new plugin as the only top level spec (not applicable for recipes or packs).

  • Proper usage of opts table rather than setting things up with the config function.

  • Proper usage of specs table for all specs that are not dependencies of a given plugin (not applicable for recipes or packs).

@pgr0ss pgr0ss changed the title Use float direction with lazyjj and jjui terminals feat(jj): Use float direction with lazyjj and jjui terminals Oct 30, 2025
@Uzaaft Uzaaft merged commit 4e3c2db into AstroNvim:main Oct 31, 2025
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants