Skip to content

If preventsAccessingMissingAttributes is enabled it throws MissingAttributeExceptions #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

If preventsAccessingMissingAttributes is enabled it throws MissingAttributeExceptions #442

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c62696f
solve MissingAttributeException
Oct 18, 2023
656662d
Merge remote-tracking branch 'Astrotomic-laravel-translatablez/main'
Feb 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,5 @@
/.phpunit.cache
/build/
/coverage.clover
.DS_Store
.idea/*
8 changes: 2 additions & 6 deletions src/Translatable/Traits/Relationship.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public function getRelationKey(): string
*/
public function getTranslationModelName(): string
{
return $this->translationModel ?: $this->getTranslationModelNameDefault();
return isset($this->translationModel) ? $this->translationModel : $this->getTranslationModelNameDefault();
}

/**
Expand Down Expand Up @@ -55,11 +55,7 @@ public function getTranslationModelNamespace(): ?string
*/
public function getTranslationRelationKey(): string
{
if ($this->translationForeignKey) {
return $this->translationForeignKey;
}

return $this->getForeignKey();
return isset($this->translationForeignKey) ? $this->translationForeignKey : $this->getForeignKey();
}

public function translation(): HasOne
Expand Down
2 changes: 1 addition & 1 deletion src/Translatable/Translatable.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ public function getDefaultLocale(): ?string
*/
public function getLocaleKey(): string
{
return $this->localeKey ?: config('translatable.locale_key', 'locale');
return isset($this->localeKey) ? $this->localeKey : config('translatable.locale_key', 'locale');
}

public function getNewTranslation(string $locale): Model
Expand Down