Skip to content

Conversation

Auburn
Copy link
Owner

@Auburn Auburn commented Nov 8, 2023

ToDo

  • 4D OpenSimplex2
  • 4D OpenSimplex2S
  • ImGui drag scaling for feature scale
  • Fix Sine low precision
  • Finish off node descriptions

@Auburn Auburn requested a review from Copilot May 30, 2025 09:57
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This release modernizes the SIMD dispatch pattern, adds scalable feature and output range controls, updates configuration paths, and renames the “NoiseTool” to “Node Editor”.

  • Replace old FS_T<> templates with FastSIMD::DispatchClass<> specializations and force-inline annotations
  • Introduce ScalableGenerator and VariableRange for feature scaling and output range handling
  • Migrate config and export headers to Utility/Config.h & Utility/Export.h, remove obsolete FastNoise_Config/Export
  • Update CMake presets, workflow files, and README to refer to the new “Node Editor” tool

Reviewed Changes

Copilot reviewed 105 out of 105 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
include/FastNoise/Generators/DomainWarpFractal.inl SIMD dispatch overhaul for domain-warp fractals
include/FastNoise/Generators/DomainWarpFractal.h Metadata updates and new FeatureSet dispatch signature
include/FastNoise/FastNoise_C.h C API signatures updated (frequency parameter removed)
CMakePresets.json Rename and normalize “tools” presets
README.md Rename “NoiseTool” references to “Node Editor”
Comments suppressed due to low confidence (4)

include/FastNoise/Generators/DomainWarpFractal.h:37

  • Typo in class name 'DomainWarpFractalIndependant' – consider renaming to 'DomainWarpFractalIndependent' for correct spelling.
class FastSIMD::DispatchClass<FastNoise::DomainWarpFractalIndependant, SIMD> final : public virtual FastNoise::DomainWarpFractalIndependant, public FastSIMD::DispatchClass<FastNoise::Fractal<FastNoise::DomainWarp>, SIMD>

CMakePresets.json:55

  • [nitpick] Inconsistent capitalization: change displayName to "Tools Debug" to match style.
"displayName": "tools Debug",

CMakePresets.json:60

  • [nitpick] Inconsistent capitalization: change displayName to "Tools Release" for consistency.
"displayName": "tools Release",

include/FastNoise/FastNoise_C.h:10

  • Removed the 'frequency' parameter from fnGenUniformGrid2D (and related) – this is an API-breaking change. Consider preserving overloads or bumping the major version.
FASTNOISE_API void* fnNewFromEncodedNodeTree( const char* encodedString, unsigned /*FastSIMD::FeatureSet*/ simdLevel /*~0u = Auto*/ );

Auburn and others added 24 commits June 5, 2025 22:46
Co-authored-by: Copilot <[email protected]>
…g existing strings, stack node end markers to reduce string length
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants