Skip to content

Fix compiler errors on Visual Studio 2022 & Add Support for CMake 4.0 #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hamedsabri wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Fix compiler errors on Visual Studio 2022 & Add Support for CMake 4.0 #316

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a71ade6
- Add policy support for CMake 4.0
hsabri-SMS Sep 20, 2025
8778676
Merge branch 'Autodesk:dev' into hsabri/fix_compiler_vs2022
hamedsabri Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.
#
cmake_minimum_required(VERSION 3.21..3.30)
cmake_minimum_required(VERSION 3.21...4.0)

project(maya-hydra)

Expand Down
3 changes: 2 additions & 1 deletion cmake/googletest_download.txt.in
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
cmake_minimum_required(VERSION 3.12.0)
cmake_minimum_required(VERSION 3.5...4.0)
Copy link
Copy Markdown
Collaborator

@debloip-adsk debloip-adsk Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Hamed, thanks for the PR! Was wondering, what's the reason for setting 3.5 as the minimum version, rather than 3.21 (which is our minimum as it is the first to support VS2022)?

Copy link
Copy Markdown
Contributor Author

@hamedsabri hamedsabri Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @debloip-adsk
No particular reason since it only applies to building gtest itself and I didn't think would cause any issues. I can bump it to 3.21 if you prefer all subprojects match mayahydra minimum.

Also, I believe this entire Gtest stuff can be upgraded and simplified ( something for another day ).

Copy link
Copy Markdown
Collaborator

@debloip-adsk debloip-adsk Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So long as this doesn't cause build issues I'm fine with it as well, we'll see with the preflight, sometimes the CMake versions can be a bit finicky

Copy link
Copy Markdown
Collaborator

@lilike-adsk lilike-adsk Oct 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-running Preflight to see if any issue

Copy link
Copy Markdown
Contributor Author

@hamedsabri hamedsabri Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ppt-adsk it looks like the errors on Linux and MacOS only. Sorry, I won't be able to look into it for now since I don't have access to those platforms. Could be related

My company is Windows only:) I miss Linux!


project(googletest-download NONE)

Expand All @@ -23,6 +23,7 @@ ExternalProject_Add(googletest
"-DBUILD_GMOCK=OFF"
"-DBUILD_SHARED_LIBS=ON"
"-DCMAKE_MACOSX_RPATH=ON"
"-DCMAKE_POLICY_VERSION_MINIMUM=3.5"
"-DCMAKE_POSITION_INDEPENDENT_CODE=ON"
"-DCMAKE_CXX_STANDARD=${CMAKE_CXX_STANDARD}"
"-DCMAKE_CXX_EXTENSIONS=${CMAKE_CXX_EXTENSIONS}"
Expand Down
3 changes: 2 additions & 1 deletion cmake/googletest_src.txt.in
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
cmake_minimum_required(VERSION 3.12.0)
cmake_minimum_required(VERSION 3.5...4.0)

project(googletest-download NONE)

Expand All @@ -20,6 +20,7 @@ ExternalProject_Add(googletest
"-DBUILD_GMOCK=OFF"
"-DBUILD_SHARED_LIBS=ON"
"-DCMAKE_MACOSX_RPATH=ON"
"-DCMAKE_POLICY_VERSION_MINIMUM=3.5"
"-DCMAKE_POSITION_INDEPENDENT_CODE=ON"
"-DCMAKE_CXX_STANDARD=${CMAKE_CXX_STANDARD}"
"-DCMAKE_CXX_EXTENSIONS=${CMAKE_CXX_EXTENSIONS}"
Expand Down
Loading