band-aid solution to updating rev sim to 2025#1118
Open
ktvuwhs wants to merge 20 commits intoAutodesk:devfrom
Open
band-aid solution to updating rev sim to 2025#1118ktvuwhs wants to merge 20 commits intoAutodesk:devfrom
ktvuwhs wants to merge 20 commits intoAutodesk:devfrom
Conversation
ktvuwhs
requested review from
BrandonPacewic and
Dhruv-0-Arora
and removed request for
a team
Member
|
@ktvuwhs Thanks for the PR. I'll be submitting some changes to your fork to make sure that this is done completely and we aren't just commenting out all the functionality. I'll probably be making alternative versions of the config classes and then removing most of the functions from |
Member
2025 Minor Simulation Tweaks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Modified vendordep JSON files and synthesis.revrobotics wrapper class files to allow Synthesis CAN simulator to work with REVLib 2025.0.0. Compatibility with 2025 was accomplished mainly by commenting out and/or removing code from the wrapper class that previously adhered to 2024 REVLib codebase that had been deprecated and removed from the 2025 codebase, as well as updating JSON files to the correct, 2025 version numbers.
Objectives
Testing Done
JIRA Issue