Conversation
Dhruv-0-Arora
added
the
ui/ux
rutmanz
left a comment
rutmanz
left a comment
There was a problem hiding this comment.
I like the font on these
The UI here doesn't seem as extensible/modifiable in the future as it could be. Ideally adding another rule would be as simple as adding the calculation function, a name, and the max value to an array, rather than require adding new inputs manually
This also isn't necessarily part of this PR because it's mostly for the UI, but I think these calculations are just not correct. My calculated height for this "robot" is about 30cm but it's reporting over 150cm. It also appears to use the bounding box of the robot (not the length of the outermost surface) which causes it to underreport non-rectangles.
Would also probably be nice to allow max values to change from year to year, as they often do
|
This appears to have made it worse (?). Synthesis and fusion swap the meaning of Y and Z (fusion has XY as the floor, but fission has XZ), and so the meaning of height for a robot that is later imported into synthesis is kind of weird (also the robot levitation appears to be based on the "down" as defined by fusion -Y, so rotating doesn't just fix it) |
rutmanz
left a comment
rutmanz
left a comment
There was a problem hiding this comment.
I think it still has the problem with concave frame perimeters (and also bumpers I suppose) but that's probably out of scope (and also maybe something we just don't deal with). lgtm
BrandonPacewic
left a comment
BrandonPacewic
left a comment
There was a problem hiding this comment.
- Needs updating towards #1194.
|
Chorus detected one or more security issues with this pull request. See the Checks tab for more details. As a reminder, please follow the secure code review process as part of the Secure Coding Non-Negotiable requirement. |
rutmanz
left a comment
rutmanz
left a comment
There was a problem hiding this comment.
Nothing shows up in the DRC tab when I run this
| html_args.returnData = "{}" | ||
|
|
||
| elif html_args.action == "designRules": | ||
| html_args.returnData = DesignRuleChecks().getDesignRules |
Dhruv-0-Arora
force-pushed
the
dhruv/1882/drc-ui-support
branch
from
8b0a66c to
0fe4a98
Compare
rutmanz
left a comment
rutmanz
left a comment
There was a problem hiding this comment.
This is what happens when I load the page on an existing assembly in fusion
rutmanz
left a comment
rutmanz
left a comment
There was a problem hiding this comment.
So at this point I think the UI is okay (could do with some colored chips around valid/invalid) but the DRC requirements change every year, and while making rulesets year-based might be out of scope for this ticket, it's so close to the end of the summer that idk if it makes sense to include the DRC ui at all because without that it's kind of a half-finished feature IMO.
|
Will not be finished as a part of the v7.2 release |
4 participants
Task
Adding the ability for users to view whether their robot design meets the guidelines outlined in the FRC inspection checklist.
AARD-1882
Solution
Created an Exporter tab that shows the user the characteristics of their design and cross check them with the FRC Inspection Checklist.
Before merging, ensure the following criteria are met: