Skip to content

feat: import unstable mira files with warnings#1301

Merged
PepperLola merged 2 commits intodevfrom
branp/unstable-field-import
Jan 10, 2026
Merged

feat: import unstable mira files with warnings#1301
PepperLola merged 2 commits intodevfrom
branp/unstable-field-import

Conversation

@BrandonPacewic
Copy link
Copy Markdown
Member

Symptom

With CAD models imported from other pieces of software there is often geometry that is unresolvable causing the importer to crash.

Solution

Detect and log common fail points of "unstable" mira files and pass over objects that are not resolvable, rather than crashing.

Verification

Importing in fission works normally.


Before merging, ensure the following criteria are met:

  • All acceptance criteria outlined in the ticket are met.
  • Necessary test cases have been added and updated.
  • A feature toggle or safe disable path has been added (if applicable).
  • User-facing polish:
    • Ask: "Is this ready-looking?"
  • Cross-linking between Jira and GitHub:
    • PR links to the relevant Jira issue.
    • Jira ticket has a comment referencing this PR.

Copy link
Copy Markdown
Member

@PepperLola PepperLola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked for me, I was able to import the new field. The one with all the gamepieces has big performance issues but it imports correctly.

@PepperLola PepperLola merged commit 8f6e215 into dev Jan 10, 2026
16 of 17 checks passed
@BrandonPacewic BrandonPacewic deleted the branp/unstable-field-import branch April 3, 2026 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants