-
Notifications
You must be signed in to change notification settings - Fork 842
Forms: fix attribute appender #45999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryCoverage changed in 1 file.
Full summary · PHP report · JS report Coverage check overridden by
Coverage tests to be added later
|
Proposed changes:
This PR is an optimization of how we inject template and widget attributes for further processing and consideration.
Related to #45997
As Claude puts it:
Other information:
Jetpack product discussion
p1763554432894829-slack-CDLH4C1UZ
Does this pull request change what data or activity we track or use?
No
Testing instructions:
Run the tests with
jetpack test php packages/forms --verbose.Look at the code change and the test cases to verify those make sense.
For real world tests, the process is in charge of adding extra attributes to forms that have been placed on widgets and templates. This means that if you log the attributes of a form block nothing should change unless the form is on one of those entities.
You can test those by switching to a theme that supports widgets, add a form to a widget and visiting on the frontend. Before the method is ran you should see the stored form attributes, after you should see an extra attribute, like
block_templateorwidgetamong the form attributes.cc @simison