Avoid requirement of double question mark#85
Open
msaggiorato wants to merge 1 commit intoAutomattic:masterfrom
Open
Avoid requirement of double question mark#85msaggiorato wants to merge 1 commit intoAutomattic:masterfrom
msaggiorato wants to merge 1 commit intoAutomattic:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After finding this issue while using inspectlet. I've noticed that sometimes URLs are going to be attempted to be normalized. That would include removing the double question mark requirement.
There's nothing preventing the whole concatenation script from working if this is requested with a single question mark.
Given that the modification tag at the end being optional, I'd say that this can be optional as well, and allow some flexibility around the URLs.
PS: Noticed this on a site hosted on WP VIP.