Skip to content

Conversation

@sjinks
Copy link
Member

@sjinks sjinks commented Jan 27, 2026

This pull request consolidates the npm prerelease publishing workflow into the main npm-publish.yml file, removing the separate prerelease workflow and improving how prerelease publishing is triggered and managed. The main improvements include combining workflows, adding support for manual triggers, and refining job conditions for clarity and correctness.

Workflow consolidation and improvements:

  • Removed the standalone .github/workflows/npm-publish-prerelease.yml file, moving all prerelease publishing logic into the main workflow.
  • Added a workflow_dispatch trigger with an npm_tag input to .github/workflows/npm-publish.yml, allowing manual prerelease publishing with custom tags.
  • Introduced a new publish-prerelease job in .github/workflows/npm-publish.yml that runs only when triggered manually, using the same steps as the removed workflow.
  • Updated the condition for the main publish job to ensure it only runs on merged pull requests, not on manual triggers.

@sjinks sjinks self-assigned this Jan 27, 2026
@sjinks sjinks requested a review from Copilot January 27, 2026 11:45
@github-actions
Copy link
Contributor

github-actions bot commented Jan 27, 2026

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

  • .github/workflows/npm-publish-prerelease.yml

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR consolidates prerelease publishing functionality into the main npm publishing workflow by removing the standalone .github/workflows/npm-publish-prerelease.yml file and incorporating its logic into .github/workflows/npm-publish.yml. This simplifies workflow management while maintaining separation between regular releases and prereleases through distinct jobs.

Changes:

  • Added workflow_dispatch trigger with npm_tag input to enable manual prerelease publishing
  • Added new publish-prerelease job that runs only on manual triggers (workflow_dispatch)
  • Updated the publish job condition to ensure it only runs on merged pull requests, not manual triggers
  • Removed the standalone prerelease workflow file

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/npm-publish.yml Added workflow_dispatch trigger, new publish-prerelease job for manual prereleases, and updated publish job condition to prevent conflicts
.github/workflows/npm-publish-prerelease.yml Removed standalone prerelease workflow as its functionality is now integrated into the main workflow

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sjinks sjinks force-pushed the trusted-publishing-for-prereleases branch from e6db1cb to 3fa7bcc Compare January 27, 2026 11:59
@sjinks sjinks requested a review from Copilot January 27, 2026 12:04
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sonarqubecloud
Copy link

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@rebeccahum rebeccahum merged commit 2663c09 into trunk Jan 27, 2026
25 checks passed
@rebeccahum rebeccahum deleted the trusted-publishing-for-prereleases branch January 27, 2026 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants