Skip to content

Conversation

Jiwoon-Kim
Copy link
Contributor

@Jiwoon-Kim Jiwoon-Kim commented Oct 3, 2025

Fixes #2286

Proposed changes:

  • Fixed typo in example federated profile: @[email protected]@[email protected]
  • Improved quoting description:
    File: src/editor-plugin/plugin.js:1
    From: "Quoting allows others to reshare your post while adding their own commentary."
    To: "Quoting allows others to cite your post while adding their own commentary."
  • Added missing i18n for advanced settings descriptions (Following User Interface, Inbox) in includes/wp-admin/class-advanced-settings-fields.php: 244, 248, 251, 283, 287

Other information:

  • Have you written new tests for your changes, if applicable?

Testing instructions:

Changelog entry

  • Automatically create a changelog entry from the details below.
Changelog Entry Details

Significance

  • Patch
  • Minor
  • Major

Type

  • Added - for new features
  • Changed - for changes in existing functionality
  • Deprecated - for soon-to-be removed features
  • Removed - for now removed features
  • Fixed - for any bug fixes
  • Security - in case of vulnerabilities

Message

Fixed typo in example, improve quoting description.

@matticbot
Copy link
Contributor

👋 Thanks for your contribution!

I see you have provided all the required changelog information in your PR description. To complete the process, you'll need to create a changelog file in your branch.

Please create a file named .github/changelog/2290-from-description with this content:

Significance: patch
Type: fixed

Correct typo, improve quoting description, and add missing i18n for advanced settings descriptions (Following UI, Inbox).

You can do this by either:

  1. Running composer changelog:add in your local repository, or
  2. Creating the file manually with the content above

Once you've committed and pushed the file to your PR branch, the checks will pass automatically.

Copy link
Member

@obenland obenland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @Jiwoon-Kim.

Changes to editor plugin files need to be made in /src/editor-plugin and then build through npm run build. It looks like so far there's only a change in the build file.

@github-actions github-actions bot added [Block] Post settings [Focus] Editor Changes to the ActivityPub experience in the block editor labels Oct 3, 2025
@Jiwoon-Kim Jiwoon-Kim requested a review from obenland October 3, 2025 17:48
@Jiwoon-Kim Jiwoon-Kim requested a review from obenland October 4, 2025 09:58
@obenland obenland merged commit 65295cf into Automattic:trunk Oct 6, 2025
14 checks passed
pfefferle pushed a commit that referenced this pull request Oct 6, 2025
pfefferle pushed a commit that referenced this pull request Oct 6, 2025
pfefferle pushed a commit that referenced this pull request Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Post settings [Feature] WP Admin [Focus] Editor Changes to the ActivityPub experience in the block editor OSS Citizen
Projects
None yet
Development

Successfully merging this pull request may close these issues.

I propose improving the string description for the ActivityPub plugin.
3 participants