-
Notifications
You must be signed in to change notification settings - Fork 85
Fix: issue #2286 – typo, improved quoting explanation, add missing i18n in advanced settings #2290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…missing i18n in advanced settings
👋 Thanks for your contribution! I see you have provided all the required changelog information in your PR description. To complete the process, you'll need to create a changelog file in your branch. Please create a file named
You can do this by either:
Once you've committed and pushed the file to your PR branch, the checks will pass automatically. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @Jiwoon-Kim.
Changes to editor plugin files need to be made in /src/editor-plugin
and then build through npm run build
. It looks like so far there's only a change in the build file.
…8n in advanced settings (#2290)
…8n in advanced settings (#2290)
…8n in advanced settings (#2290)
Fixes #2286
Proposed changes:
@[email protected]
→@[email protected]
File: src/editor-plugin/plugin.js:1
From: "Quoting allows others to reshare your post while adding their own commentary."
To: "Quoting allows others to cite your post while adding their own commentary."
Added missing i18n for advanced settings descriptions (Following User Interface, Inbox) inincludes/wp-admin/class-advanced-settings-fields.php: 244, 248, 251, 283, 287
Other information:
Testing instructions:
Go to WordPress admin → Settings → ActivityPub → AdvancedCheck that the "Following User Interface" and "Inbox" descriptions now have proper i18n appliedChangelog entry
Changelog Entry Details
Significance
Type
Message
Fixed typo in example, improve quoting description.